Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development updates #552

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

BrianHawley
Copy link
Contributor

Summary

Update development dependencies and other development-related fixes.

Details

  • Update appraisal now that the issue blocking the update is fixed.
  • Relax the version range of aruba so the latest version can be used.
  • Ignore .ruby-gemset for developers who use gemsets.

Motivation and Context

Improve development, and keep things up to date.

How Has This Been Tested?

This only affects development and testing, so I ran the test suite. No failures.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

- Update appraisal now that the issue blocking the update is fixed.
- Relax the version range of aruba so the latest version can be used.
- Ignore .ruby-gemset for developers who use gemsets.
@@ -12,3 +12,4 @@ Gemfile.lock
spec/examples.txt
.idea
.ruby-version
.ruby-gemset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels super archaic. But ok.

Copy link
Contributor Author

@BrianHawley BrianHawley Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luke-hill pretty standard for rvm use, but even some rbenv users use the gemset plugin to make it less awkward to work on many projects (in my case dozens) on the same machine. It comes in handy.

@luke-hill luke-hill merged commit b4481c3 into cucumber:main Jun 28, 2022
@aslakhellesoy
Copy link
Contributor

Hi @BrianHawley,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants