Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rule feature to test using tags #1549

Merged
merged 5 commits into from
Jul 9, 2021
Merged

Conversation

luke-hill
Copy link
Contributor

Allow Rules to be used in cucumber-ruby

cucumber-ruby

  • Fix the rule test to use a tagged rule

gherkin

  • Fix GherkinQuery to build up the backward looking tag logic when in Rule as well as Feature (Previously just used feature).

Additional context
Needs to be merged AFTER the gherkin fix.

@luke-hill
Copy link
Contributor Author

This will fail CI currently. Once I've then merged in the fix to gherkin it should then pass.

@aurelien-reeves
Copy link
Contributor

Could we have a scenario which tries filtering on the rule's tag?

@luke-hill
Copy link
Contributor Author

I think you can see that in the "passing" commit, it did actually pass. I just forgot a line of the tag (Which I copied in the latter commit).

@luke-hill
Copy link
Contributor Author

Note to all: This requires a new version of gherkin-ruby (Slated to be v19.0.4), which in turn will require other things updating first. It is a hard-blocker that those items are released before this PR can be rebased and merged.

@luke-hill luke-hill merged commit d88d9a7 into main Jul 9, 2021
@luke-hill luke-hill deleted the bugfix/enable_tagged_rules branch July 9, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants