Methods for Step Definitions #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a symbol is passed to a step definition, then that symbol will be sent to the World object. The symbol must therefore refer to a method defined by the World: either in an included module or on the World object. The proc can still be used, but if a symbol is provided the proc will be ignored. Also, support executing the symbol against objects other than the World. If an :on key is provided to the options hash then the proc attached to this will be evaluated against the World, and then the symbol sent to the result of that proc, rather than directly to the World itself.
|
Thanks for this patch - it's a great idea! Sorry we took so long to merge it in. Your ticket actually prompted a huge long navel-gazing exercise within the core team about what else we could do to make it easier to write maintainable step definitions, and in the mean time we forgot all about your orignal ticket. Thanks for contributing to Cucumber. |
|
No worries, thanks for pulling it in. I've been wanting to use this for awhile now. Out of curiosity, what are the other things that you can do? |
|
This needs a blog article to tell us all about it. :) |
|
Wow, very nice addition. Kudos. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to write step definitions without attaching a block directly in-line. Like so:
Given /^I am using "([^"]+)" as the payment recipient$/, :select_recipient
Where select_recipient(name) is a method on the current World. Additionally, I'd like to be able to execute the method against any arbitrary object, as long as it could be reach from the World. Like so:
Given /^I am using "([^"]+)" as the payment recipient$/, :select_recipient, :on => lambda { current_user }
Where the lambda under the key :on is executed within the World, and the method is then sent to the returned object.
I feel that using this approach may encourage more maintainable step definition implementations by making it more straightforward to just wire steps up to page and persona objects.