Around hooks not executing in correct world context #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattwynne using an around hook to prepare the world has changed the way some of the errors are reported. Is there anything that jumps out as something we need to do to change this? The problem with preparing the world in a before hook is that they run after any around hooks, so the world that the rest of the test case is executed against has not been initialised yet. |
tooky
force-pushed
the
hooks-inconsistent-world
branch
from
fdfa55c
to
9c4b282
Compare
tooky
force-pushed
the
hooks-inconsistent-world
branch
from
9c4b282
to
6438302
Compare
mattwynne
force-pushed
the
hooks-inconsistent-world
branch
2 times, most recently
from
41d2337
to
32a1a9f
Compare
|
@tooky I think this is good to go. Can you tidy up the commits and merge (or use --squash) if you agree? |
This ensures that prepare world is the first thing that is run for a test case, preventing the inconsistency with what the world _is_ in around hooks. Legacy adapter requires each test case to have a test step otherwise it doesn't switch step container and messages get lost. Also ensures failures in Around hooks are reported.
tooky
force-pushed
the
hooks-inconsistent-world
branch
from
32a1a9f
to
1f3714d
Compare
tooky
added a commit
that referenced
this pull request
Mar 18, 2015
Execute around hooks correctly within the world
|
thanks @tooky! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #640.
Based on @maxlinc's example this scenario demonstrates that the world an around hook is being instance_exec'd on is not quite right.
For the first scenario, self is nil, and the next scenario the world is remembered from the previous scenario.