messages/javascript: replace tslint with eslint #837
Conversation
- switch off a couple of eslint rules it looks like we don't want - use eslint-plugin-node for equivalent of "no-implicit-dependencies" - slight refactor to avoid no-constant-condition
| @@ -5,7 +5,6 @@ coverage/ | |||
| node_modules/ | |||
| yarn.lock | |||
| npm-debug.log | |||
| package-lock.json | |||
There was a problem hiding this comment.
Not sure if this was intentional originally, but meant volatile builds were possible unless I missed something.
| @@ -15,13 +15,14 @@ export default class BinaryToMessageStream<T> extends Transform { | |||
|
|
|||
| public _transform(chunk: any, encoding: string, callback: TransformCallback) { | |||
| this.buffer = Buffer.concat([this.buffer, chunk]) | |||
|
|
|||
| while (true) { | |||
| let finished = false | |||
There was a problem hiding this comment.
The only actual code change - seemed worthwhile to avoid ignoring the no-constant-condition rule which would otherwise be useful. This is covered by an existing test.
|
Looking for feedback at this point before doing anything with other TypeScript packages in this repo e.g. expressions |
aslakhellesoy
added
language: javascript
🔧 build
|
I'm close to finishing this one. Because we use shared linting config across packages this turned out to be quite big, but important to get done I think. |
|
@vincent-psarga I also removed the |
Summary
This replaces TSLint with ESLint and appropriate tooling and config.
Details
Using equivalents as much as possible, e.g.
tslint:latest->eslint:recommendedtslint-config-prettier->eslint-config-prettierand minimal actual code change.
Motivation and Context
TSLint is deprecated and its maintainers now recommend ESLint.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: