Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Marathi translation #731

Merged
merged 1 commit into from Oct 8, 2019
Merged

Conversation

upgundecha
Copy link
Contributor

Added Marathi translation to Gherkin

Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it would be good to have someone who understands the language. I couldn't even tell you where to find a country that spoke this translation sadly :(

If possible could you find someone who perhaps could validate the entries?

}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just check your editor with regards to auto-sanitizing json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure @luke-hill, thanks!

@aslakhellesoy
Copy link
Contributor

I couldn't even tell you where to find a country that spoke this translation sadly :(

@luke-hill - @upgundecha provided a Wikipedia link that answers your question.

I am sure @upgundecha is a native speaker of Marathi (since he submitted a translation) so we do not need anyone else to validate this. Thanks @upgundecha!

aslakhellesoy added a commit that referenced this pull request Oct 8, 2019
@aslakhellesoy aslakhellesoy merged commit b2e0c6b into cucumber:master Oct 8, 2019
@aslakhellesoy
Copy link
Contributor

Hi @upgundecha,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@upgundecha
Copy link
Contributor Author

upgundecha commented Oct 8, 2019

Thanks, @aslakhellesoy @luke-hill

Marathi is a native language spoken by over 100 million people in India (2019). There are more than 200K Marathi speakers in the US, Europe and Australia.

aslakhellesoy added a commit that referenced this pull request Oct 14, 2019
@upgundecha upgundecha deleted the marathi branch October 15, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants