Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #114] Add javascript example "Feature-coupled step definitions (anti-pattern)" #113

Closed
mlvandijk opened this issue Feb 25, 2018 · 5 comments · Fixed by #114
Closed

[PR #114] Add javascript example "Feature-coupled step definitions (anti-pattern)" #113

mlvandijk opened this issue Feb 25, 2018 · 5 comments · Fixed by #114
Labels
good first issue Good for newcomers language: javascript 🙏 help wanted Help wanted - not prioritized by core team
Projects
Go Live

Comments

@mlvandijk
Copy link
Member

There's one example missing for javascript in anti-patterns.md.
Java and Ruby examples for same are provided.
Missing example is marked "TODO" in the file.
@mlvandijk mlvandijk added 🙏 help wanted Help wanted - not prioritized by core team good first issue Good for newcomers language: javascript labels Feb 25, 2018
@xtrasimplicity
Copy link
Member

anti-patterns.md doesn't exist anymore. Are you referring to the section under best-practices.md?
https://github.com/cucumber/docs.cucumber.io/pull/77/files#diff-4a8d0ea6f2837fa485124e7c637a80af
https://github.com/cucumber/docs.cucumber.io/pull/77/files#diff-3dce5767c9e094a30439b02976597ca4

@mlvandijk
Copy link
Member Author

Hi @xtrasimplicity - thanks for pointing that out. I was working on a different branch when I wrote this issue. Yes, I mean an example in the best-practices.md for the "Feature-coupled step definitions (anti-pattern)". I'll update the title.

@mlvandijk mlvandijk changed the title Add javascript example to anti-patterns.md Add javascript example "Feature-coupled step definitions (anti-pattern)" Feb 28, 2018
@mlvandijk
Copy link
Member Author

Background info: We're still working on the structure of the docs / navbar, see here: #109 - where we may split best-practices again.

@xtrasimplicity
Copy link
Member

Brilliant, thanks for clearing that up. I'll take a look at this when I get a chance. :)

@mlvandijk
Copy link
Member Author

That would be great, thnx! :)

xtrasimplicity added a commit to xtrasimplicity/docs.cucumber.io that referenced this issue Mar 3, 2018
@xtrasimplicity
Added JS example Anti-Pattern. Resolves cucumber#113
6ec7487
@xtrasimplicity xtrasimplicity mentioned this issue Mar 3, 2018
Merged
@mlvandijk mlvandijk added this to In progress in Go Live Mar 6, 2018
@mlvandijk mlvandijk changed the title Add javascript example "Feature-coupled step definitions (anti-pattern)" [PR #114] Add javascript example "Feature-coupled step definitions (anti-pattern)" Mar 6, 2018
xtrasimplicity added a commit to xtrasimplicity/docs.cucumber.io that referenced this issue Mar 7, 2018
@xtrasimplicity
Added JS example Anti-Pattern. Resolves cucumber#113
3460460
@mlvandijk mlvandijk moved this from In progress to Done in Go Live Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers language: javascript 🙏 help wanted Help wanted - not prioritized by core team
Projects
No open projects
Go Live
  
Done
Milestone
No milestone
2 participants
@xtrasimplicity @mlvandijk