Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language tabs lack accessibility #628

Open
UltimateGeek opened this issue Jun 9, 2021 · 7 comments
Open

Language tabs lack accessibility #628

UltimateGeek opened this issue Jun 9, 2021 · 7 comments
Labels
✅ accepted The core team has agreed that it is a good idea to fix this

Comments

@UltimateGeek
Copy link

The language tabs have the following deficiencies:

  1. There are not obvious
    • Consequence: new users may not even notice that they can switch between the tabs to see different language support.
  2. They don't have the names of the languages: neither by default (only an image is shown representing the language), nor by tooltip (when hovering over the tab, it does not show you the name of the language)
    • Consequence: users unfamiliar with the icon representations don't know what language the documentation is on
@mattwynne
Copy link
Member

You make some excellent points @UltimateGeek

It sounds like you have expertise in this area. Is there any chance you would be willing to help us fix these issues? We can give you as much support as you need.

@mattwynne mattwynne added the ✅ accepted The core team has agreed that it is a good idea to fix this label Jun 9, 2021
@aslakhellesoy
Copy link
Contributor

We've discussed this previously in the open source weekly meetings.

I think we should abandon the whole language tab idea and move more of the platform-specific documentation to plain old GitHub Markdown files in the respective Cucumber-* repositories. We're doing this already here: https://github.com/cucumber/cucumber-js#documentation

The reason I want to abandon it is that it's too difficult to write documentation this way. There are lots of if statements in the Markdown code to display/hide contents for various languages.

  • Some sections don't have language specific content and just show up blank
  • Some content is so platform-specific that we couldn't possibly have language-specific content
  • These if statements are cumbersome to edit
  • We cannot easily version the docs (but we can if we do like Cucumber.js does)
  • It's easier for contributors to update docs when they are in the same repo as the code

We can keep high-level platform-agnostic content where it is now though.

  • We cannot version the docs

@aslakhellesoy
Copy link
Contributor

@mattwynne
Copy link
Member

IMO it's useful to have the option to provide language specific docs sometimes, so I wouldn't want to throw the baby out with the bathwater.

I agree that some of the pages have got a bit ridiculous with their if statements. I'm ambivalent about whether moving those docs off the /docs site is a good idea. It might be simpler to just copy/paste those pages for specific languages and suffer a bit of duplication in the prose. We know from past efforts that any significant change to the docs site is a heavyweight undertaking and I'm not sure this is a priority right now.

@mattwynne
Copy link
Member

I wonder if we should create a separate ticket for your proposal @aslakhellesoy so we don't derail from the original point of this issue. Obviously we need to resolve your point too, but they're separate threads I think.

@aurelien-reeves
Copy link
Contributor

Done.
So this ticket is now dedicated to improving the language tabs: adding proper text and/or title on it for example.

To discuss more general improvements of the doc, please go in #633

@davidjgoss
Copy link
Contributor

I ran up a small change just to add title attrs, meaning (for sighted users) you can at least hover and get the tooltip:

However I had a quick play with VoiceOver and the tabs don't seem to be very accessible in general (with or without that change) - needs a bit more looking at I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ accepted The core team has agreed that it is a good idea to fix this
Projects
None yet
Development

No branches or pull requests

5 participants