Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate gherkin-i18n-table based on json of gherkin repo #936

Closed
WikiRik opened this issue Nov 24, 2023 · 5 comments · Fixed by #972
Closed

Automate gherkin-i18n-table based on json of gherkin repo #936

WikiRik opened this issue Nov 24, 2023 · 5 comments · Fixed by #972

Comments

@WikiRik
Copy link
Member

WikiRik commented Nov 24, 2023

🤔 What's the problem you're trying to solve?

When looking at the docs you can find a table of the translations, but it's not up to date. It can be updated manually but I think it would be nicer if it is in sync with the gherkin repo itself.

✨ What's your proposed solution?

It would be nice if the gherkin-i18n-table would be generated based on the json in the gherkin repo which to my understanding is the most up to date version.

⛏ Have you considered any alternatives or workarounds?

As mentioned above; updating can be done manually. We can also look at the json instead of the docs.

📚 Any additional context?


This text was originally generated from a template, then edited by hand. You can modify the template here.

@mlvandijk
Copy link
Member

Would you be up for contributing such a change @WikiRik ?

@WikiRik WikiRik mentioned this issue Dec 1, 2023
1 task
@WikiRik
Copy link
Member Author

WikiRik commented Dec 1, 2023

Apparently it's already possible, but it's a manual process now. See https://github.com/cucumber/docs/blob/main/layouts/shortcodes/README.md
Would you be okay with me adding a GitHub action that runs every week or so to check if there are any updates and if so, commit and open a PR?

In the meantime I've opened #939 so at least we're up to date now

@WikiRik
Copy link
Member Author

WikiRik commented Jan 19, 2024

@mlvandijk did you get a chance to look at my idea of adding a GitHub Action to check for updates regularly?

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Mar 25, 2024

@WikiRik if you're still interested building it, I would be interested a PR that automates this with a Github action. Do bear in mind that because this repository is relatively open, it will have to work without secrets.

@WikiRik
Copy link
Member Author

WikiRik commented Mar 25, 2024

@mpkorstanje That's understandable, I'll take a look at it and see what I can get working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants