Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Add 'regel' for 'rule' in Dutch #170

Merged
merged 1 commit into from Sep 8, 2023
Merged

i18n: Add 'regel' for 'rule' in Dutch #170

merged 1 commit into from Sep 8, 2023

Conversation

Coedice
Copy link
Member

@Coedice Coedice commented Sep 8, 2023

Added a translation of "rule" in Dutch: "regel"

Resolves: #105

@luke-hill
Copy link
Contributor

Can you add a changelog entry @Coedice

@luke-hill luke-hill merged commit b7d583e into main Sep 8, 2023
25 checks passed
@luke-hill luke-hill deleted the dutch-regel branch September 8, 2023 08:15
@smuller-nl
Copy link

I didn't see this change mentioned in the change log at https://github.com/cucumber/cucumber-js/blob/main/CHANGELOG.md , now our current Dutch feature files with "Rule" suddenly did not parse anymore after an upgrade of cucumber 10.0 to 10.3. And the Localization documentation at https://cucumber.io/docs/gherkin/languages/#gherkin-dialect-nl-content still mentions "Rule" instead of "Regel" for the nl language. Wouldn't it be better if both "Rule" and "Regel" are possible in the nl language feature? @Coedice @luke-hill

@luke-hill
Copy link
Contributor

luke-hill commented Mar 25, 2024

I didn't see this change mentioned in the change log at https://github.com/cucumber/cucumber-js/blob/main/CHANGELOG.md

So you wouldn't see a dutch changelog entry there @smuller-nl however ideally an update similar to this one should have been added: cucumber/cucumber-ruby@b6779f3#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR15

And the Localization documentation at https://cucumber.io/docs/gherkin/languages/#gherkin-dialect-nl-content still mentions "Rule" instead of "Regel" for the nl language.

The docs there aren't directly tied to the active codebase. See cucumber/docs#936 raised recently to tackle this.

Wouldn't it be better if both "Rule" and "Regel" are possible in the nl language feature? @Coedice @luke-hill

This goes against the language paradigms of gherkin. If you want to mix-n-match your language prefs then gherkin won't be able to tell them apart. You can use * as a language agnostic keyword to tackle this if you'd prefer?

@smuller-nl
Copy link

Thank you @luke-hill for your swift reply. We had lost some time hunting for the reason why our feature files didn't parse anymore, and the change log and the localisation docs is where we had looked, but didn't find anything. My suggestions were just to prevent others losing time if in the future similar changes are made. Implementing cucumber/docs#936 would certainly help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Dutch translation of "rule" in Gherkin
3 participants