Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to use same version numbers #76

Merged
merged 3 commits into from
Nov 14, 2017
Merged

Add note to use same version numbers #76

merged 3 commits into from
Nov 14, 2017

Conversation

mlvandijk
Copy link
Member

Should solve #17

Copy link
Contributor

@aslakhellesoy aslakhellesoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you convert this into a {{% tip %}} box instead?

Or better, make a red {{% note %}} box. Copy the tip.html shortcode to note.html and style it with red. See bulma docs for what css class to use.

@mlvandijk
Copy link
Member Author

@aslakhellesoy I've added a {{% note %}} shortcode and tagged the notes as such.
Red was a bit much imho, so I opted to style in black ('is-dark') for now. Found the bulma info: https://bulma.io/documentation/components/message :)

@@ -1,4 +1,4 @@
<article class="message is-primary">
<article class="message is-primare">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo or the real class name?

@olleolleolle
Copy link
Contributor

Looks good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants