Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatter does not preserve trailing comments #38

Closed
xeger opened this issue Sep 21, 2023 · 1 comment
Closed

Formatter does not preserve trailing comments #38

xeger opened this issue Sep 21, 2023 · 1 comment

Comments

@xeger
Copy link
Member

xeger commented Sep 21, 2023 •
edited
Loading

👓 What did you see?

When the final lines of a block are commented, the formatter removes them from its output.

✅ What did you expect to see?

Comments should be preserved.

📦 Which tool/library version are you using?

Version 8.0.5 of this package.

🔬 How could we reproduce it?

See this branch for a reproduction of the problem in unit tests.
This was referenced Sep 21, 2023
Closed
Closed
@xeger xeger changed the title Formatter does not preserve trailing comments Formatter does not preserve trailing comments & adds newlines in the wrong places Oct 4, 2023
xeger added a commit that referenced this issue Oct 15, 2023
@xeger
Preserve trailing comments after feature. Fixes #38 partially.
2045072
@xeger xeger changed the title Formatter does not preserve trailing comments & adds newlines in the wrong places Formatter does not preserve trailing comments Oct 15, 2023
xeger added a commit that referenced this issue Oct 15, 2023
@xeger
Preserve trailing comments. Fixes #38.
85eb3aa 
Also eliminate useless trailing space after `:`
when the node has no `name`.
@xeger xeger mentioned this issue Oct 15, 2023
Merged
5 tasks
xeger added a commit that referenced this issue Oct 15, 2023
@xeger
Preserve trailing comments. Fixes #38.
b1d0b49 
Also eliminate useless trailing space after `:`
when the node has no `name`.
@xeger xeger closed this as completed in a220d98 Oct 23, 2023
@jeeeem
Copy link

jeeeem commented Oct 24, 2023

Awesome, any plan in including this update in vscode extension next release?

This was referenced Nov 4, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xeger @jeeeem