-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure to start extension under latest VS Code #155
Comments
Since VS Code 1.78.0 was released, it happens there as well. I see the following message in the output for the Cucumber Language Server: [Error - 10:58:18 AM] Server initialization failed.
Message: Request initialize failed with message: abort(Assertion failed: bad export type for `tree_sitter_c_sharp_external_scanner_create`: undefined). Build with -s ASSERTIONS=1 for more info.
Code: -32603
[Error - 10:58:18 AM] Cucumber Language Server client: couldn't create connection to server.
Message: Request initialize failed with message: abort(Assertion failed: bad export type for `tree_sitter_c_sharp_external_scanner_create`: undefined). Build with -s ASSERTIONS=1 for more info.
Code: -32603 And the output from 2023-05-05 10:58:18.201 [info] ExtensionService#_doActivateExtension CucumberOpen.cucumber-official, startup: false, activationEvent: 'onLanguage:cucumber'
2023-05-05 10:58:18.257 [error] Activating extension CucumberOpen.cucumber-official failed due to an error:
2023-05-05 10:58:18.257 [error] Error: Request initialize failed with message: abort(Assertion failed: bad export type for `tree_sitter_c_sharp_external_scanner_create`: undefined). Build with -s ASSERTIONS=1 for more info.
at kr (/home/dgedon/.vscode/extensions/cucumberopen.cucumber-official-1.7.0/out/extension.js:8:228)
at Yt (/home/dgedon/.vscode/extensions/cucumberopen.cucumber-official-1.7.0/out/extension.js:7:6885)
at Immediate.<anonymous> (/home/dgedon/.vscode/extensions/cucumberopen.cucumber-official-1.7.0/out/extension.js:7:6732)
at process.processImmediate (node:internal/timers:466:21)
2023-05-05 10:58:19.259 [error] Error: Client is not running and can't be stopped. It's current state is: starting
at Hv.shutdown (/home/dgedon/.vscode/extensions/cucumberopen.cucumber-official-1.7.0/out/extension.js:67:8644)
at Hv.stop (/home/dgedon/.vscode/extensions/cucumberopen.cucumber-official-1.7.0/out/extension.js:67:8223)
at Hv.stop (/home/dgedon/.vscode/extensions/cucumberopen.cucumber-official-1.7.0/out/extension.js:67:50251)
at Hv.doInitialize (/home/dgedon/.vscode/extensions/cucumberopen.cucumber-official-1.7.0/out/extension.js:67:8048)
at async Hv.start (/home/dgedon/.vscode/extensions/cucumberopen.cucumber-official-1.7.0/out/extension.js:67:4618) |
I got this error after having the latest update of VSCode, here are my extension host logs for further info:
|
A workaround can be to downgrade to the previous VSCode version. I'm using |
Reproduced with my system : Version: 1.78.0 (user setup)
|
Is this more related to https://github.com/cucumber/language-service rather than this repo itself? I asked because it looks very similar with this issue and tree-sitter stuffs are related to language-service as its dependencies. |
Hi, |
same issue here. |
facing same issue |
Aparently, this is connected to this: microsoft/vscode#166265 |
Same issue.... |
@xeger has created a patched (hacked) version here: https://github.com/xeger/cucumber-vscode/releases/tag/v1.7.1 that fixes the problem, but it won't be released; you must download it and install it locally if you want to test it. He considers this to be a hack because the real problem is in the tree-sitter code; it doesn't play well with Electron 22 and the latest version of V8. Once a new tree-sitter is released that fixes the problem we won't need the hack. The tree-sitter problem has been discussed extensively and there is an open PR that appears to fix it: |
Is there an alternative to Cucumber? My team is very unhappy about them not being able to use the cool Cucumber Extension for their gherkin code. |
Name: Cucumber (Gherkin) Full Support This one is also good, i was using it for a long time before knowing the official one. |
Surprisingly, this is working again for me with the newest VSCode. |
Still not working for me on VSCode 1.79.2 and Cucumber plugin v1.7.0, both of which appear to be the latest. |
Hi,
Could you share your version with us plz ?
Thx
Envoyé à partir de Outlook pour Android<https://aka.ms/AAb9ysg>
…________________________________
De : DerZyklop ***@***.***>
Envoyé : mercredi, juillet 5, 2023 12:57:48 PM
À : cucumber/vscode ***@***.***>
Cc : jtournemine ***@***.***>; Comment ***@***.***>
Objet : Re: [cucumber/vscode] Failure to start extension under latest VS Code (Issue #155)
Surprisingly, this is working again for me with the newest VSCode.
—
Reply to this email directly, view it on GitHub<#155 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACYFJYTW5JTQDPK7OWJO5YDXOVCCVANCNFSM6AAAAAAXNDBF7U>.
You are receiving this because you commented.Message ID: ***@***.***>
|
@jtournemine |
I have VSCode: I uninstalled @xeger's patched version and installed 1.7.0 from the Visual Studio Marketplace; it failed immediately with "couldn't create connection to server". |
Who is now working on this issue to get it fixed? Should it be fixed in VSCode or the extension itself? |
@patrickschilder It must first be fixed in tree-sitter; once a fixed version is released then a new version of the VSCode plugin can be released. Xeger's patched version works pretty well; it doesn't always identify Gherkin that doesn't have a matching step definition, but go-to-definition works, syntax highlighting works, auto-complete works, and it usually identifies Gherkin that doesn't have a step definition. I am using that until a new official version is available. |
Is it possible to include this fix #165 in the unofficial version (1.7.1)? This fix is for comments that are being strip when formatting. |
@jeeeem just a note that I have included (at least some) comment-stripping fixes in the unofficial build. Are you still seeing all comments stripped while using it? |
Same error using: Version: 1.81.1 but no problem with same VS Code version on Windows 10 |
Thank you for the bug report. This is fixed in v1.8.0 which should be published to the Visual Studio Code Marketplace soon, or you can install from the |
Sorry for the late reply got busy at work, I just tried the new version (1.8) and it is now working perfectly with this version of VSCode
but I still encountering the comment issue, whenever there are comments in the end of feature file, it automatically deletes it. sample.recording.mp4 |
Argh @jeeeem; it seems that I've failed to upgrade one of the underlying dependencies to a new-enough version. :( I will need to make a new release tonight, to fix this behavior. |
Thanks will wait for the new release. Hopefully that will fix the issue. |
Upon further investigation @jeeeem this is a corner case that our original comment-preservation work failed to fix. Basically, leading and inline comments inside a block are preserved; it's just trailing comments that get removed. Still pretty disruptive, so I'll encourage us to work on a fix as time permits. |
That's unfortunate, I guess, for now, I will avoid commenting at the end of the file at the moment. Although I'm glad the problem with LSP now works perfectly. Hoping this will be fixed sooner. Anyways, thanks for update. @xeger |
same issue as well.
and
shall wwe reopen or create a new issue ? |
Sorry for the confusion and my previous comment. I removed it and added my finding to #234 |
👓 What did you see?
Upon opening up any *.feature file, I see:
No syntax highlighting, or any features are then produced.
✅ What did you expect to see?
I expected the extension to start properly, and have syntax highlighting, etc.
📦 Which tool/library version are you using?
Cucumber VS Code Plugin: v1.7.0
VS Code (Insiders):
My guess is that it has to do with:
🔬 How could we reproduce it?
Be on the latest version of VS Code
Open up any *.feature file.
EDIT: This relates to -- microsoft/vscode#166265
The text was updated successfully, but these errors were encountered: