Embed common packages from monorepo #428
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
make common
target to copymessages
andgherkin
packages from common monorepo intogodog
's internal. This is an alternative solution to migrate away fromgithub.com/cucumber/messages-go
andgithub.com/cucumber/gherkin-go
while not depending on a monorepo.Motivation & context
Once common monorepo has an update in
gherkin
and/ormessages
, agodog
maintainer can runmake common
and create a PR with produced changes.Pros:
messages
package is not directly importable by end-usersCons:
godog
repointernal/messages
in case they need it for advanced step definitions (can be solved by providing more local aliases ingodog
package)common
packages (though it would still be manual when importing common directly)golint
and is excluded from linting (may be fixed in monorepo, but with breraking changes in symbol names)Resolves #389.
Type of change
work as expected)
Note to other contributors
No notes.
Update required of cucumber.io/docs
No update.
Checklist: