Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move messages to stand-alone repo #2029

Closed
mattwynne opened this issue Jun 28, 2022 · 4 comments · Fixed by #2089
Closed

Move messages to stand-alone repo #2029

mattwynne opened this issue Jun 28, 2022 · 4 comments · Fixed by #2089
Assignees
@aurelien-reeves
Labels
✨ kaizen Continuous improvement initiatives. See https://github.com/orgs/cucumber/projects/9

Comments

@mattwynne
Copy link
Member

No description provided.

@mattwynne mattwynne added the ✨ kaizen Continuous improvement initiatives. See https://github.com/orgs/cucumber/projects/9 label Jun 28, 2022
@aurelien-reeves
Copy link
Contributor

https://github.com/cucumber/messages

@aurelien-reeves
Copy link
Contributor

aurelien-reeves commented Jul 1, 2022 •
edited by mattwynne
Loading

Todo list (for at least go, java, javascript, perl, php and ruby - dotnet is ignored for now, elixir may require additional work in parallel of #1952):

  • Add tests as part of the CI
  • Add code generation as part of dev workflow (still relying on make, but only dedicated to code generation)
  • Check as part of the CI that generated code in the repo is up-to-date with the schemas
  • Clean-up the repo
    • Synchronize READMEs accross languages to avoid package managers without READMEs
    • Write some doc / contributing doc
  • Add release workflows (Release workflows messages#27)
    • Do not forget post-release processes
      • among others: java (done with polyglot release)
      • among others: php (dependency updates should be done using renovate or dependabot)
  • Release
  • Migrate issues / PRs

Depending on the status of the elixir piece of work, do not forget to

  • Remove protocol buffer from elixir
    • in test-elixir.yml (WIP in a PR)

aurelien-reeves added a commit to cucumber/messages that referenced this issue Jul 5, 2022
@aurelien-reeves
Rework code generation for Perl
1d50591 
The part regarding the README which was copied from the parent folder
will be managed later. It is part of the TODO list here:
cucumber/common#2029
aurelien-reeves added a commit to cucumber/messages that referenced this issue Jul 6, 2022
@aurelien-reeves
New Code Generation (#16)
e269fd3 
* Rework code generation for Ruby

* Rework code generation for Javascript

* Rework code generation for Java

* Rework code generation for Go

* Rework code generation for Perl

The part regarding the README which was copied from the parent folder
will be managed later. It is part of the TODO list here:
cucumber/common#2029

* Add some requirements checks in java makefile

* Rework code generation for PHP

* Rework root Makefile

* Add validation of schemas into root makefile

* Add a workflow to check there is no need to generate code

* Fix workflow

* Fix set up of node in test-codegen workflow

* Add missing checkout step into test-codegen workflow

* Fix 'composer install' instruction in test-codegen workflow

* Update messages.md to test the test-codegen workflow

* Run clean-all before generate-all in test-codegen workflow

* Fix messages.md to fix the test-codegen workflow
This was referenced Jul 12, 2022
Merged
Closed
@mattwynne mattwynne mentioned this issue Aug 12, 2022
Merged
11 tasks
@mattwynne
Copy link
Member Author

mattwynne commented Aug 12, 2022 •
edited
Loading

@aurelien-reeves thanks for all your work on this! I've had a busy few weeks and am only just picking this up. I don't quite have enough context to help with the task about synchronizing the readmes - do you mean we could copy / paste a standard README file manually into each language sub-folder? Or did you mean something more fancy and automated?

I've made a start on the release workflows, but we will need help from Wannes, Ciaran and Erik to get the Elixir, PHP and Perl releases working I think.

This was referenced Aug 12, 2022
Closed
Closed
@aurelien-reeves
Copy link
Contributor

@mattwynne regarding the readmes, I had no idea in mind. I just wanted to avoid missing readmes with npm or such package managers. That could be done manually.

For the release workflows:

  • we don't care the for Elixir one at the moment: the actual implementation is not maintained, outdated, and unused. The next one is still WIP
  • I am pretty sure we already have some Perl release workflow somewhere
  • For PHP, this is based on git tags, like go-lang. This is using a sub-repo at the moment

This was referenced Sep 20, 2022
Closed
Merged
cukebot pushed a commit to cucumber/messages-go that referenced this issue Sep 21, 2022
@aurelien-reeves
New Code Generation (#16)
56c41d9 
* Rework code generation for Ruby

* Rework code generation for Javascript

* Rework code generation for Java

* Rework code generation for Go

* Rework code generation for Perl

The part regarding the README which was copied from the parent folder
will be managed later. It is part of the TODO list here:
cucumber/common#2029

* Add some requirements checks in java makefile

* Rework code generation for PHP

* Rework root Makefile

* Add validation of schemas into root makefile

* Add a workflow to check there is no need to generate code

* Fix workflow

* Fix set up of node in test-codegen workflow

* Add missing checkout step into test-codegen workflow

* Fix 'composer install' instruction in test-codegen workflow

* Update messages.md to test the test-codegen workflow

* Run clean-all before generate-all in test-codegen workflow

* Fix messages.md to fix the test-codegen workflow
cukebot pushed a commit to cucumber/messages-php that referenced this issue Sep 21, 2022
@aurelien-reeves
New Code Generation (#16)
e9ffee5 
* Rework code generation for Ruby

* Rework code generation for Javascript

* Rework code generation for Java

* Rework code generation for Go

* Rework code generation for Perl

The part regarding the README which was copied from the parent folder
will be managed later. It is part of the TODO list here:
cucumber/common#2029

* Add some requirements checks in java makefile

* Rework code generation for PHP

* Rework root Makefile

* Add validation of schemas into root makefile

* Add a workflow to check there is no need to generate code

* Fix workflow

* Fix set up of node in test-codegen workflow

* Add missing checkout step into test-codegen workflow

* Fix 'composer install' instruction in test-codegen workflow

* Update messages.md to test the test-codegen workflow

* Run clean-all before generate-all in test-codegen workflow

* Fix messages.md to fix the test-codegen workflow
@mattwynne mattwynne mentioned this issue Sep 30, 2022
Merged
This was referenced Nov 10, 2022
Closed
Merged
@otrava7 otrava7 mentioned this issue Dec 30, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aurelien-reeves aurelien-reeves

Labels
✨ kaizen Continuous improvement initiatives. See https://github.com/orgs/cucumber/projects/9
Projects
Split up the monorepo
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove messages cucumber/common
2 participants
@mattwynne @aurelien-reeves