-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support elixir #82
Support elixir #82
Conversation
9d30bb0
to
138b05c
Compare
c65e425
to
8ef4e0a
Compare
In cucumber/messages#46 I took the decision to change the But we won't know until we try it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing quite a few fixtures for Elixer, yet the release proces only involves a single file. I don't immediately see what those fixtures are for. Perhaps they can be cleaned up.
Yeah, I just used their |
Regarding the As for the fixtures, I'm not completely up to date what "technical flow" would be. Is this a file that'd be copied to the respective messages/elixir folder after which the release process would be started there? Or is there a reason why a new project would be generated with |
Thinking about it, given we only touch the |
🤔 What's changed?
⚡️ What's your motivation?
#80 => cucumber/messages#46 => cucumber/messages#45 => cucumber/common#2029
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
The fixture was generated using
mix new
which made aproject
with aversion
string value. When I look at the code fromcucumber/messages
I see we've used a@vsn
attribute(?) on the module.I've decided to go with what
mix new
generated, and I think that, unless there's a good reason, we should changecucumber/messages
to hardcode theversion
in theproject
as in the generated file.@WannesFransen1994 do you see any problem with this? Any idea why the
@vsn
attribute was used originally?📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.