-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cue/cmd: export encoding is hiding errors #1153
Comments
Related to #1152 |
Thanks for raising this, @verdverm. I think the following captures the essence of the bug:
Namely that regardless of export format, we should be seeing an error related to the incomplete-ness of (grr, hit Cmd+Enter instead of enter!) The current output is:
Confirmed with 370fac9. |
This is an intriguing case. One could argue that this is not an incomplete error. According to the current CUE spec, it should be an error though. I guess in the future we could relax this, if we can define a good way to hold this. |
What type of error do you think it should be? |
Fixes cue-lang#1152 Fixes cue-lang#1153 Signed-off-by: Marcel van Lohuizen <mpvl@golang.org> Change-Id: Ida2ba39e361621dba1c5a14bfa45bae004de893c Signed-off-by: Marcel van Lohuizen <mpvl@golang.org> Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/528037 Reviewed-by: Marcel van Lohuizen <mpvl@gmail.com> Unity-Result: CUEcueckoo <cueckoo@cuelang.org> TryBot-Result: CUEcueckoo <cueckoo@cuelang.org> Signed-off-by: Joel Longtine <joel@longtine.io>
What version of CUE are you using (
cue version
)?0.4.0
What did you do?
Given
foo.cue
No error is printed, but exit code is 1
Specifying the output format does help a little
What did you expect to see?
errors about V2 not being concrete
The text was updated successfully, but these errors were encountered: