Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evaluator: enable use of new evaluator via CUE_EXPERIMENT #2886

Closed
myitcv opened this issue Feb 29, 2024 · 1 comment
Closed

evaluator: enable use of new evaluator via CUE_EXPERIMENT #2886

myitcv opened this issue Feb 29, 2024 · 1 comment
Assignees
@mpvl
Labels
evaluator

Comments

@myitcv
Copy link
Member

myitcv commented Feb 29, 2024

This is a placeholder issue for providing a means of enabling the new evaluator.

It is a follow-up to #2884.

The new evaluator will not be enabled by default: an uncontrolled flip from one evaluator to another would be an incredibly risky and unnecessary move.

Instead we will allow people to "opt in" to the new evaluator, and plan to do that via CUE_EXPERIMENT. CUE_EXPERIMENT is an environment variable, the value of which allows you to set certain switches. For example, we have done this for modules, where CUE_EXPERIMENT=modules enables modules. Note the value of CUE_EXPERIMENT is likely to be a comma-separated list of values (possibly key-value pairs).
@myitcv myitcv mentioned this issue Feb 29, 2024
Open
@mpvl mpvl mentioned this issue Feb 29, 2024
Open
@myitcv myitcv mentioned this issue Apr 4, 2024
Open
cueckoo pushed a commit that referenced this issue Apr 4, 2024
@mpvl
internal/core/adt: add methods for accessing Conjuncts
0501113 
The new evaluator uses a tree of conjuncts, instead of
a list. Much of the existing code does not handle this
properly.

The plan is to replace access to Conjuncts with the
use of visitor methods.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo pushed a commit that referenced this issue Apr 4, 2024
@mpvl
tools/trim: update for new evaluator
f1a71b6 
Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo pushed a commit that referenced this issue Apr 4, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
d7f4a8f 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo pushed a commit that referenced this issue Apr 10, 2024
@mpvl
internal/core/adt: add methods for accessing Conjuncts
6d63f77 
The new evaluator uses a tree of conjuncts, instead of
a list. Much of the existing code does not handle this
properly.

The plan is to replace access to Conjuncts with the
use of visitor methods.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo pushed a commit that referenced this issue Apr 10, 2024
@mpvl
tools/trim: update for new evaluator
2be1c20 
Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo pushed a commit that referenced this issue Apr 10, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
978ce88 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo pushed a commit that referenced this issue Apr 10, 2024
@mpvl
internal/core/adt: add methods for accessing Conjuncts
a6c0def 
The new evaluator uses a tree of conjuncts, instead of
a list. Much of the existing code does not handle this
properly.

The plan is to replace access to Conjuncts with the
use of visitor methods.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo pushed a commit that referenced this issue Apr 10, 2024
@mpvl
tools/trim: update for new evaluator
fbdaeec 
Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo pushed a commit that referenced this issue Apr 10, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
36cf31d 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo pushed a commit that referenced this issue Apr 11, 2024
@mpvl
internal/core/adt: add methods for accessing Conjuncts
89ac177 
The new evaluator uses a tree of conjuncts, instead of
a list. Much of the existing code does not handle this
properly.

The plan is to replace access to Conjuncts with the
use of visitor methods.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo pushed a commit that referenced this issue Apr 11, 2024
@mpvl
tools/trim: update for new evaluator
2ba2897 
Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo pushed a commit that referenced this issue Apr 11, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
cf28031 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo pushed a commit that referenced this issue Apr 11, 2024
@mpvl
internal/core/adt: add methods for accessing Conjuncts
1cbff26 
The new evaluator uses a tree of conjuncts, instead of
a list. Much of the existing code does not handle this
properly.

The plan is to replace access to Conjuncts with the
use of visitor methods.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo pushed a commit that referenced this issue Apr 11, 2024
@mpvl
tools/trim: update for new evaluator
af6f918 
Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo pushed a commit that referenced this issue Apr 11, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
5b45479 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo pushed a commit that referenced this issue Apr 11, 2024
@mpvl
internal/core/adt: add methods for accessing Conjuncts
0d8f7c7 
The new evaluator uses a tree of conjuncts, instead of
a list. Much of the existing code does not handle this
properly.

The plan is to replace access to Conjuncts with the
use of visitor methods.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo pushed a commit that referenced this issue Apr 11, 2024
@mpvl
tools/trim: update for new evaluator
d5261d3 
Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo pushed a commit that referenced this issue Apr 11, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
37a8580 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo pushed a commit that referenced this issue Apr 11, 2024
@mpvl
internal/core/adt: add methods for accessing Conjuncts
f21553f 
The new evaluator uses a tree of conjuncts, instead of
a list. Much of the existing code does not handle this
properly.

The plan is to replace access to Conjuncts with the
use of visitor methods.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo pushed a commit that referenced this issue Apr 11, 2024
@mpvl
tools/trim: update for new evaluator
8a7bd18 
Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo pushed a commit that referenced this issue Apr 11, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
d01a5f3 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo pushed a commit that referenced this issue Apr 12, 2024
@mpvl
internal/core/adt: add methods for accessing Conjuncts
1242fb1 
The new evaluator uses a tree of conjuncts, instead of
a list. Much of the existing code does not handle this
properly.

The plan is to replace access to Conjuncts with the
use of visitor methods.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo pushed a commit that referenced this issue Apr 12, 2024
@mpvl
tools/trim: update for new evaluator
a4a93b5 
Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo pushed a commit that referenced this issue Apr 12, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
a546a30 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo pushed a commit that referenced this issue Apr 15, 2024
@mpvl
internal/core/adt: add methods for accessing Conjuncts
749ea92 
The new evaluator uses a tree of conjuncts, instead of
a list. Much of the existing code does not handle this
properly.

The plan is to replace access to Conjuncts with the
use of visitor methods.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo pushed a commit that referenced this issue Apr 15, 2024
@mpvl
tools/trim: update for new evaluator
46dccb9 
Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo pushed a commit that referenced this issue Apr 15, 2024
@mpvl
internal/core/adt: add methods for accessing Conjuncts
4fcfdbf 
The new evaluator uses a tree of conjuncts, instead of
a list. Much of the existing code does not handle this
properly.

The plan is to replace access to Conjuncts with the
use of visitor methods.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1191581
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
cueckoo pushed a commit that referenced this issue Apr 15, 2024
@mpvl
tools/trim: update for new evaluator
416c163 
Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1191582
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
cueckoo pushed a commit that referenced this issue Apr 16, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
cba54ab 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo pushed a commit that referenced this issue Apr 16, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
9868c07 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo pushed a commit that referenced this issue Apr 16, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
eb9a63b 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo pushed a commit that referenced this issue Apr 16, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
3f028df 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo pushed a commit that referenced this issue Apr 17, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
8f5c618 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo pushed a commit that referenced this issue Apr 17, 2024
@mpvl
cmd/cue/cmd: expose evalv3 experiment
d65019d 
Right now this is only done through a global variable
for the cue command line. It is not possible to set this
through the API.

Note: do not close this issue until we allow exposing the
experiment everywhere in the API.

Issue #2886

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1191591
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
@mvdan mvdan mentioned this issue Apr 18, 2024
Open
@mvdan
Copy link
Member

mvdan commented Apr 18, 2024

v0.9.0-alpha.2 is released with the availability of CUE_EXPERIMENT=evalv3: https://github.com/cue-lang/cue/releases/tag/v0.9.0-alpha.2

@mvdan mvdan closed this as completed Apr 18, 2024
@mvdan mvdan mentioned this issue Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpvl mpvl

Labels
evaluator
Projects
Evaluator Roadmap
Status: Done
Release v0.9
Status: v0.9.0-alpha.2
Milestone
No milestone
Development

No branches or pull requests
3 participants
@myitcv @mvdan @mpvl