-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evaluator: enable use of new evaluator via CUE_EXPERIMENT #2886
Labels
Comments
Open
cueckoo
pushed a commit
that referenced
this issue
Apr 4, 2024
The new evaluator uses a tree of conjuncts, instead of a list. Much of the existing code does not handle this properly. The plan is to replace access to Conjuncts with the use of visitor methods. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo
pushed a commit
that referenced
this issue
Apr 4, 2024
Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo
pushed a commit
that referenced
this issue
Apr 4, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo
pushed a commit
that referenced
this issue
Apr 10, 2024
The new evaluator uses a tree of conjuncts, instead of a list. Much of the existing code does not handle this properly. The plan is to replace access to Conjuncts with the use of visitor methods. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo
pushed a commit
that referenced
this issue
Apr 10, 2024
Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo
pushed a commit
that referenced
this issue
Apr 10, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo
pushed a commit
that referenced
this issue
Apr 10, 2024
The new evaluator uses a tree of conjuncts, instead of a list. Much of the existing code does not handle this properly. The plan is to replace access to Conjuncts with the use of visitor methods. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo
pushed a commit
that referenced
this issue
Apr 10, 2024
Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo
pushed a commit
that referenced
this issue
Apr 10, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo
pushed a commit
that referenced
this issue
Apr 11, 2024
The new evaluator uses a tree of conjuncts, instead of a list. Much of the existing code does not handle this properly. The plan is to replace access to Conjuncts with the use of visitor methods. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo
pushed a commit
that referenced
this issue
Apr 11, 2024
Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo
pushed a commit
that referenced
this issue
Apr 11, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo
pushed a commit
that referenced
this issue
Apr 11, 2024
The new evaluator uses a tree of conjuncts, instead of a list. Much of the existing code does not handle this properly. The plan is to replace access to Conjuncts with the use of visitor methods. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo
pushed a commit
that referenced
this issue
Apr 11, 2024
Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo
pushed a commit
that referenced
this issue
Apr 11, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo
pushed a commit
that referenced
this issue
Apr 11, 2024
The new evaluator uses a tree of conjuncts, instead of a list. Much of the existing code does not handle this properly. The plan is to replace access to Conjuncts with the use of visitor methods. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo
pushed a commit
that referenced
this issue
Apr 11, 2024
Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo
pushed a commit
that referenced
this issue
Apr 11, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo
pushed a commit
that referenced
this issue
Apr 11, 2024
The new evaluator uses a tree of conjuncts, instead of a list. Much of the existing code does not handle this properly. The plan is to replace access to Conjuncts with the use of visitor methods. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo
pushed a commit
that referenced
this issue
Apr 11, 2024
Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo
pushed a commit
that referenced
this issue
Apr 11, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo
pushed a commit
that referenced
this issue
Apr 12, 2024
The new evaluator uses a tree of conjuncts, instead of a list. Much of the existing code does not handle this properly. The plan is to replace access to Conjuncts with the use of visitor methods. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo
pushed a commit
that referenced
this issue
Apr 12, 2024
Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo
pushed a commit
that referenced
this issue
Apr 12, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo
pushed a commit
that referenced
this issue
Apr 15, 2024
The new evaluator uses a tree of conjuncts, instead of a list. Much of the existing code does not handle this properly. The plan is to replace access to Conjuncts with the use of visitor methods. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5
cueckoo
pushed a commit
that referenced
this issue
Apr 15, 2024
Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034
cueckoo
pushed a commit
that referenced
this issue
Apr 15, 2024
The new evaluator uses a tree of conjuncts, instead of a list. Much of the existing code does not handle this properly. The plan is to replace access to Conjuncts with the use of visitor methods. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Idba1f3af0ede1184932c6152b4e5a2cd92e510c5 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1191581 Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com> TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
cueckoo
pushed a commit
that referenced
this issue
Apr 15, 2024
Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Ice6396f576b47b0f5de01a69743258a13b00f034 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1191582 TryBot-Result: CUEcueckoo <cueckoo@cuelang.org> Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
cueckoo
pushed a commit
that referenced
this issue
Apr 16, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo
pushed a commit
that referenced
this issue
Apr 16, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo
pushed a commit
that referenced
this issue
Apr 16, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo
pushed a commit
that referenced
this issue
Apr 16, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo
pushed a commit
that referenced
this issue
Apr 17, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f
cueckoo
pushed a commit
that referenced
this issue
Apr 17, 2024
Right now this is only done through a global variable for the cue command line. It is not possible to set this through the API. Note: do not close this issue until we allow exposing the experiment everywhere in the API. Issue #2886 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I445485d905a21831ae1395a9d3dc78c19365a11f Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1191591 Reviewed-by: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: CUEcueckoo <cueckoo@cuelang.org> Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a placeholder issue for providing a means of enabling the new evaluator.
It is a follow-up to #2884.
The new evaluator will not be enabled by default: an uncontrolled flip from one evaluator to another would be an incredibly risky and unnecessary move.
Instead we will allow people to "opt in" to the new evaluator, and plan to do that via
CUE_EXPERIMENT
.CUE_EXPERIMENT
is an environment variable, the value of which allows you to set certain switches. For example, we have done this for modules, whereCUE_EXPERIMENT=modules
enables modules. Note the value ofCUE_EXPERIMENT
is likely to be a comma-separated list of values (possibly key-value pairs).The text was updated successfully, but these errors were encountered: