-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it public #4
Conversation
@pachCode @rogelioLpz actualmente esta fallando Travis porque el proyecto no es OpenSource, en cuanto le den aprobar, lo haré público y todo debería funcionar |
try: | ||
kinesis_client.create_stream(StreamName=stream_name, ShardCount=1) | ||
except kinesis_client.exceptions.ResourceInUseException: | ||
time.sleep(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Para que es el sleep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cuando haces muchas peticiones seguidas, AWS te manda esa excepción.
hub/workers/worker.py
Outdated
tries=None, | ||
num_workers=1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agregar type hinting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Listo
record_ok = dict( | ||
uuid='f3296986-ded8-11e9-8000-000000000000', | ||
task='registered_task', | ||
headers=dict(), | ||
body=dict(), | ||
) | ||
|
||
record_missing_task = dict( | ||
uuid='t89876702-cas9-22g1-9000-000000000000', | ||
task='missing_task', | ||
headers=dict(), | ||
body=dict(), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Los objetos que se leen de Kinesis tienen la siguiente estructura
https://docs.aws.amazon.com/en_us/kinesis/latest/APIReference/API_Record.html
Sería más apropiado tener esa misma estructura en los objetos del Test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
La idea de la función process_records
es qué solo procese esos records.
Puedes ver en el listener
que ya solo envía la parte de Data
, esto porque SequenceNumber
y otros datos no son necesarios para procesar un record, entonces no tiene sentido estarlos enviando por todas las funciones
hub/workers/__init__.py
Outdated
return workers_created | ||
|
||
|
||
def find_decorated_functions(module): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agregar type hinting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Listo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cuál es el ideal de números de workers que se deben inicializar?
closes #2
closes #3