Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with browserify #477

Merged
merged 1 commit into from
Dec 24, 2015
Merged

Issue with browserify #477

merged 1 commit into from
Dec 24, 2015

Conversation

Kyos
Copy link
Contributor

@Kyos Kyos commented Dec 24, 2015

What's this PR purpose?

When you try to browserify a file which require when, you get this error :

Error: Cannot find module '../when' from '/Users/olivierlaniesse/src/iadvize/test/node_modules/when/dist/browser'
    at /Users/olivierlaniesse/src/iadvize/test/node_modules/browserify/node_modules/resolve/lib/async.js:55:21
    at load (/Users/olivierlaniesse/src/iadvize/test/node_modules/browserify/node_modules/resolve/lib/async.js:69:43)
    at onex (/Users/olivierlaniesse/src/iadvize/test/node_modules/browserify/node_modules/resolve/lib/async.js:92:31)
    at /Users/olivierlaniesse/src/iadvize/test/node_modules/browserify/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:99:15)

This PR aims to fix it 😃

Step to reproduce

  1. npm install --save when browserify
  2. Edit a js file with this code (aka : test.js) :
require('when')
  1. run : browserify test.js
  2. Read the error :)

Environnement

  • npm v2.14.11
  • when 3.7.6

Signed-off-by: Olivier LANIESSE <o.laniesse@gmail.com>
@briancavalier
Copy link
Member

Reproduced! Thank you for the level of detail, and for the fix, @Kyos :)

briancavalier added a commit that referenced this pull request Dec 24, 2015
@briancavalier briancavalier merged commit bd2c2fb into cujojs:master Dec 24, 2015
@Kyos Kyos deleted the hotfix-browserify branch December 24, 2015 15:33
@briancavalier
Copy link
Member

Just published 3.7.7 with this fix. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants