Links with foreignIdentityField
#403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any chance of getting this looked at and possibly merged? |
Merged
|
@bhunjadi please resolve the conflicts and merge from master to run the tests. |
bhunjadi
force-pushed
the
feature/link-foreign-field
branch
from
c84445e
to
ee69644
Compare
bhunjadi
force-pushed
the
feature/link-foreign-field
branch
from
ee69644
to
b4656c0
Compare
|
@StorytellerCZ |
StorytellerCZ
requested changes
Oct 25, 2023
| } | ||
|
|
||
| throw new Meteor.Error('invalid-type', `Unrecognized type: ${typeof what} for managing links`); | ||
| } | ||
|
|
||
| getId(what, options) { | ||
| if (typeof what === 'string') { | ||
| if (_.isString(what)) { |
There was a problem hiding this comment.
Any reason why use underscore instead of native?
There was a problem hiding this comment.
I think I just followed the standard practice in the repo in 2019.
I'll change it.
|
Also I think this will need an addition to the docs. |
|
Docs & readme updated. Also removed _.isString() |
StorytellerCZ
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of a feature as discussed in #396