Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nested links #479

Merged

Conversation

bhunjadi
Copy link
Contributor

@bhunjadi bhunjadi commented Oct 25, 2023

Support for nested links in nested objects and arrays:

Coll.addLinks({
  'meta.project': {
    collection: Projects,
    type: 'one',
    field: 'meta.projectId',
  },
})

@bhunjadi
Copy link
Contributor Author

@StorytellerCZ

This is another PR from my repo that I didn't submit here before. I'll try to add basically everything from my fork to PRs here to have them more in sync (or ideally I'd just abandon my fork).

It's in draft because it's best to merge #403 first and then I'll make additional changes here.

@StorytellerCZ StorytellerCZ marked this pull request as ready for review November 6, 2023 19:08
@StorytellerCZ
Copy link
Collaborator

#403 was merged.

@bhunjadi
Copy link
Contributor Author

@StorytellerCZ This should be ready for a review now.

Copy link
Collaborator

@StorytellerCZ StorytellerCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing that I can pick up is an optional use of Array.isArray over _.isArray

lib/links/lib/createSearchFilters.js Outdated Show resolved Hide resolved
@StorytellerCZ StorytellerCZ added this to the V1.5 milestone Feb 28, 2024
@bhunjadi
Copy link
Contributor Author

bhunjadi commented Mar 4, 2024

@StorytellerCZ Fixed in the latest commit

@StorytellerCZ StorytellerCZ merged commit 5d65ea7 into cult-of-coders:master Mar 11, 2024
6 checks passed
@StorytellerCZ
Copy link
Collaborator

Will be published in v1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants