-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Release 1.2 #136
Merged
Merged
[RFC] Release 1.2 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sort, fixed optimistic ui for direct processing
theodorDiaconu
commented
Mar 16, 2017
|
||
let directSubs = RedisSubscriptionManager.store[channel + '::' + doc._id]; | ||
if (directSubs && directSubs.length) { | ||
directSubs.forEach(subscriber => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to put channelLastIds until you find a better way for optimistic ui
theodorDiaconu
changed the title
[WIP] Feature/performance and others
[WIP] Release 1.2 - The mark of PROD-ready.
Mar 17, 2017
…sort, fixed optimistic ui for direct processing
theodorDiaconu
changed the title
[WIP] Release 1.2 - The mark of PROD-ready.
[RFC] Release 1.2 - The mark of PROD-ready.
Mar 17, 2017
Is there a chance to get a way to generally turn on optimistic ui? |
@maxnowack yes, will add it as setting. |
…omputation when pushToRedis is false
theodorDiaconu
changed the title
[RFC] Release 1.2 - The mark of PROD-ready.
[RFC] Release 1.2
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Fix limit-sort processing strategy with negative fields #135
Fixed Different behavior with reactive sources #137
Fixed Redis Monitor #94
Fixed Exception in callback of async function: TypeError: callback is not a function #138
Fixed Optimistic UI Improvements #124
fix Exception in callback of async function: TypeError: callback is not a function #138 - when pushToRedis is false don't perform additional computations
create defaults for mutation config like {pushToRedis: false, optimistic: true}
solve optimistic ui using the strategy specified in Optimistic UI Improvements #124 . The idea breaks when publishComposite is in use. It will cause some delays for methods.
Redis Monitor #94 - Create a RedisOplog.stats() function which shows information about current publications, how many observers they have, how much memory it is ocuppying, etc. Should return an object.
Write custom publish-composite that works with this perfectly.
add pushToRedis and optimistic as configurable stuff