Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Release 1.2 #136

Merged
merged 21 commits into from
Mar 21, 2017
Merged

[RFC] Release 1.2 #136

merged 21 commits into from
Mar 21, 2017

Conversation

theodorDiaconu
Copy link
Contributor

@theodorDiaconu theodorDiaconu commented Mar 16, 2017


let directSubs = RedisSubscriptionManager.store[channel + '::' + doc._id];
if (directSubs && directSubs.length) {
directSubs.forEach(subscriber => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to put channelLastIds until you find a better way for optimistic ui

@theodorDiaconu theodorDiaconu changed the title [WIP] Feature/performance and others [WIP] Release 1.2 - The mark of PROD-ready. Mar 17, 2017
@theodorDiaconu theodorDiaconu changed the title [WIP] Release 1.2 - The mark of PROD-ready. [RFC] Release 1.2 - The mark of PROD-ready. Mar 17, 2017
@maxnowack
Copy link
Contributor

Is there a chance to get a way to generally turn on optimistic ui?

@theodorDiaconu
Copy link
Contributor Author

@maxnowack yes, will add it as setting.

@theodorDiaconu theodorDiaconu changed the title [RFC] Release 1.2 - The mark of PROD-ready. [RFC] Release 1.2 Mar 21, 2017
@theodorDiaconu theodorDiaconu merged commit a55de80 into master Mar 21, 2017
@theodorDiaconu theodorDiaconu deleted the feature/performance-and-others branch March 21, 2017 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants