Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Export ValueType from react-select in Select #494

Merged
merged 1 commit into from
May 18, 2020
Merged

chore: Export ValueType from react-select in Select #494

merged 1 commit into from
May 18, 2020

Conversation

dougmacknz
Copy link
Contributor

react-select has this frustrating type on their onChange prop. This hasn't been any issue for us so far because in Flow you don't have to specify the type for this param, but in TypeScript we have to. So we'll need this ValueType type.

JedWatson/react-select#2902

@dougmacknz dougmacknz requested a review from a team May 18, 2020 06:15
@dougmacknz dougmacknz merged commit 8524476 into master May 18, 2020
@dougmacknz dougmacknz deleted the dug/react-select-value-type branch May 18, 2020 06:29
This was referenced May 18, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebpearce sebpearce sebpearce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougmacknz @sebpearce