ci: Setup for project references #919
Conversation
… consistent with naming in other packages
…ultureamp/kaizen-design-system into ally/form-consolidate-packages
ActuallyACat
changed the title
| @@ -0,0 +1,134 @@ | |||
| /* eslint import/no-extraneous-dependencies: 0 */ | |||
There was a problem hiding this comment.
Technically, since this is a story and not something that is to be distributed, I could have linked to this file that is also present in draft-packages/hierarchical-menu/docs/hierarchicalStoriesHelpers.ts. It felt like code smell / something that would encourage bad practice so I have duplicated this file instead.
There was a problem hiding this comment.
Ah ok, so with this new structure, every package's stories should be self-contained?
In this case, hierarchical-select uses hierarchical-menu internally. So we're saying it's ok to reference other packages for implementation code, but not for the stories.
There was a problem hiding this comment.
Yeah, pretty much. The stories are not within the distributed package so one would have to import using a relative link.
| @@ -9,3 +9,4 @@ lerna-*.log | |||
| /packages/**/*.js.map | |||
| /packages/**/*.d.ts | |||
| .DS_Store | |||
| dist | |||
There was a problem hiding this comment.
In the future, all distributed assets will belong in a dist directory instead of being compiled in place.
| @@ -0,0 +1,134 @@ | |||
| /* eslint import/no-extraneous-dependencies: 0 */ | |||
There was a problem hiding this comment.
Ah ok, so with this new structure, every package's stories should be self-contained?
In this case, hierarchical-select uses hierarchical-menu internally. So we're saying it's ok to reference other packages for implementation code, but not for the stories.
Objective
This PR moves all stories to their corresponding package and ensures the stories are not bundled when publishing.
Motivation and Context
This is a task in my housekeeping list and is something (comparatively) small that I could slice out of the project references work: https://cultureamp.atlassian.net/wiki/spaces/DesignSystem/pages/1924630820/Kaizen+Housekeeping
Checklist
[ ] If this contains visual changes, has it been reviewed by a designer?
[ ] I have considered likely risks of these changes and got someone else to QA as appropriate
[ ] I have or will communicate these changes to the front end practice