Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

III-4788 Change error responses to return correct API problems #210

Merged
merged 10 commits into from
Jun 23, 2022
Merged

III-4788 Change error responses to return correct API problems #210

merged 10 commits into from
Jun 23, 2022

Commits on Jun 13, 2022

  1. Convert query param exceptions to correct Api Problem response

    @bertramakers
    bertramakers committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    2e36143 View commit details
    Browse the repository at this point in the history

  2. Convert MissingParameter exception to correct Api Problem

    @bertramakers
    bertramakers committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    5b6d586 View commit details
    Browse the repository at this point in the history

  3. Reduce code duplication

    @bertramakers
    bertramakers committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    1630507 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Use correct content-type for API problems

    @bertramakers
    bertramakers committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    8520e64 View commit details
    Browse the repository at this point in the history

  2. Convert MethodNotAllowedException to correct API problem

    @bertramakers
    bertramakers committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    d47ae26 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Change OPTIONS routes so we get a NotFoundException instead of Method… 

    …NotAllowed exception for unknown paths

The wildcard route matched every possible path, so for example a GET /foobar would return a method not allowed (because OPTIONS would be allowed on it)
    @bertramakers
    bertramakers committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    40c5ac6 View commit details
    Browse the repository at this point in the history

  2. Convert NotFoundException to correct API problem

    @bertramakers
    bertramakers committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    5b5024e View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Don't throw if an invalid URL is given as website query param

    @bertramakers
    bertramakers committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    1f93366 View commit details
    Browse the repository at this point in the history

  2. Linting™

    @bertramakers
    bertramakers committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    1610c51 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Add test for invalid urls

    @bertramakers
    bertramakers committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    84e8207 View commit details
    Browse the repository at this point in the history