Provide default values for new widget parameters

[boonebgorges]

When you introduced the new title_element field, it broke existing widgets, because no element at all was provided. In cases like this, where you introduce a new value, you should provide a default value. (In fact, it's a good idea to provide a default value in all cases.)

Basically, you might want to try something like this at the top of cac-featured-controller.php or thereabouts:

$defaults = array(
    'featured_content_type' => 'member',
    'custom_description' => '',
    // etc
);

$params = wp_parse_args( $params, $defaults );

This is a handy way of making sure that required fields (like title_element) are never left empty.

(I did notice that you have an Upgrade Notice that warns people that they'll need to resave their widgets. Providing default values will make it so that people don't have to do this. Also, people don't really read those :) )

[humanshell]

I was curious about this when releasing the latest version. I was worried that the update warning could go unnoticed. I'll add the defaults code to the description request from issue #3 for a 1.0.4 release. I'll update you when the new code gets pushed up.

[boonebgorges]

Thanks!

On 11/28/12 16:37, Dominic Giglio wrote:

I was curious about this when releasing the latest version. I was
worried that the update warning could go unnoticed. I'll add the
defaults code to the description request from issue #3
#3
for a 1.0.4 release. I'll update you when the new code gets pushed up.

—
Reply to this email directly or view it on GitHub
#4 (comment).