Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] fix diagflat fail if argument is not cupy.ndarray #1058

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

okuta
Copy link
Member

@okuta okuta commented Mar 26, 2018

Backport of #1036

fix diagflat fail if argument is not cupy.ndarray
@okuta okuta added backport Pull-requests backported from development branch cat:bug Bugs labels Mar 26, 2018
@kmaehashi kmaehashi self-assigned this Mar 26, 2018
@kmaehashi kmaehashi added the st:test-and-merge (deprecated) Ready to merge after test pass. label Mar 26, 2018
@kmaehashi kmaehashi added this to the v4.0.0 milestone Mar 26, 2018
@kmaehashi
Copy link
Member

Jenkins, test this please.

1 similar comment
@kmaehashi
Copy link
Member

Jenkins, test this please.

@kmaehashi kmaehashi merged commit 18f8745 into cupy:v4 Mar 28, 2018
@kmaehashi
Copy link
Member

LGTM!

@okuta okuta deleted the bp-1036-fix-diagflat branch March 28, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull-requests backported from development branch cat:bug Bugs st:test-and-merge (deprecated) Ready to merge after test pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants