Improve memory allocation performance #1343
Conversation
okuta
added
cat:performance
okuta
force-pushed
the
improve-memory
branch
2 times, most recently
from
c241f49
to
a13db44
Compare
|
jenkins, test this please. |
|
Jenkins CI test (for commit 6752a44) failed with status FAILURE. |
|
jenkins, test this please. |
|
Jenkins CI test (for commit 6752a44) failed with status FAILURE. |
|
jenkins, test this please. |
|
Jenkins CI test (for commit 6752a44, target branch master) failed with status FAILURE. |
|
jenkins, test this please. |
|
Jenkins CI test (for commit 0d89993, target branch master) succeeded! |
| @@ -166,10 +167,11 @@ cdef class _Chunk: | |||
|
|
|||
| def __init__(self, *args): | |||
| # For debug | |||
| self._init(*args) | |||
| mem, offset, size, stream_ptr = args | |||
There was a problem hiding this comment.
Why don't you directly write __init__(self, mem, offset, size, stream_ptr)?
There was a problem hiding this comment.
BTW, it looks this method is only used for debugging. Is it related to the performance improvement?
There was a problem hiding this comment.
This is to avoid compile error because _init is a cdef method.
| @@ -617,13 +665,12 @@ cdef class SingleDeviceMemoryPool: | |||
|
|
|||
| cpdef Py_ssize_t _round_size(self, Py_ssize_t size): | |||
| """Rounds up the memory size to fit memory alignment of cudaMalloc.""" | |||
| unit = self._allocation_unit_size | |||
| cdef Py_ssize_t unit = self._allocation_unit_size | |||
There was a problem hiding this comment.
Memo: this annotation is needed to let Cython avoid inferring the type of unit as Python int.
|
LGTM |
Improve memory allocation performance
rel #1340.