Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Use "x mod 1" to generate [0, 1)-uniform random #1710

Merged
merged 1 commit into from
Oct 12, 2018
Merged

[backport] Use "x mod 1" to generate [0, 1)-uniform random #1710

merged 1 commit into from
Oct 12, 2018

Conversation

takagi
Copy link
Member

@takagi takagi commented Oct 12, 2018

Backport of #1701

@takagi
Merge pull request cupy#1701 from toslunar/rng-uniform-mod1
c5a68f4 
Use "x mod 1" to generate [0, 1)-uniform random
@takagi takagi added backport Pull-requests backported from development branch cat:bug Bugs labels Oct 12, 2018
@takagi
Copy link
Member Author

takagi commented Oct 12, 2018

[automatic post] Jenkins, test this please.

@takagi takagi added this to the v5.0.0 milestone Oct 12, 2018
@chainer-ci
Copy link
Member

Jenkins CI test (for commit c5a68f4, target branch v5) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@takagi
Copy link
Member Author

takagi commented Oct 12, 2018

Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit c5a68f4, target branch v5) succeeded!

toslunar
toslunar approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar merged commit b10428c into cupy:v5 Oct 12, 2018
@toslunar toslunar self-assigned this Oct 12, 2018
@kmaehashi kmaehashi changed the title [backport] Use "x mod 1" to generate [0, 1)-uniform random [backport] Use "x mod 1" to generate [0, 1)-uniform random Oct 25, 2018
@takagi takagi deleted the bp-1701-rng-uniform-mod1 branch May 28, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees

@toslunar toslunar

Labels
backport Pull-requests backported from development branch cat:bug Bugs
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@takagi @chainer-ci @toslunar