Support cuDNN CTC functions #1769

aonotas · 2018-11-01T11:28:12Z

Add cuDNN CTC functions.
This cuDNN CTC is supported from v7.

cudnnCreateCTCLossDescriptor
cudnnDestroyCTCLossDescriptor
cudnnSetCTCLossDescriptor
cudnnGetCTCLossDescriptor
cudnnGetCTCLossWorkspaceSize
cudnnCTCLoss

okuta · 2018-11-02T01:31:20Z

cupy/cudnn.pyx

@@ -382,6 +382,13 @@ def set_dropout_descriptor(desc, handle, dropout):
    cudnn.setDropoutDescriptor(desc.value, handle, dropout, 0, 0, 0)


+def create_ctc_loss_descriptor(data_type):


I want to hide descriptor and wrap cuDNN interface because raw cuDNN API is too complex.

This is high level API example.

cupy/cupy/cudnn.pyx

Line 311 in 834f9f3

def activation_forward(core.ndarray x, int mode, double coef=0.0):

Cloud you remove this function from this PR?

OK. Thank you for your comment.
Do you mean should I define the other high level API function like following?

# in cupy/cudnn.pyx def ctc_loss(data_type, other_args_for_cudnnCTCLoss): # create descriptor desc = Descriptor(cudnn.createCTCLossDescriptor(), py_cudnn.destroyCTCLossDescriptor) cudnn.setCTCLossDescriptor(desc.value, data_type) # compute workspace getCTCLossWorkspaceSize(hoge, worksize) # allocate worksize workspace = ... # compute CTC loss CTCLoss(hoge, workspace, other_args_for_cudnnCTCLoss) return loss, gradients

Yes, something like that.

Cloud you rename this function or delete this?

Suggested change

def create_ctc_loss_descriptor(data_type):

def _create_ctc_loss_descriptor(data_type):

cupy/cuda/cudnn.pyx

okuta · 2018-11-02T01:33:49Z

jenkins, test this please.

chainer-ci · 2018-11-02T01:59:58Z

Jenkins CI test (for commit 2309250, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Co-Authored-By: aonotas <nanigashi03@gmail.com>

aonotas · 2018-11-06T03:40:03Z

Can you check this comments when you can time?
#1769 (comment)

aonotas · 2018-11-12T06:51:39Z

In ctc function, I found these things:
In these two functions, we should set CPU pointer (labelLengths, inputLengths, labels).

cudnnGetCTCLossWorkspaceSize
cudnnCTCLoss
when we set GPU pointer, it occurs 'segment fault'.

so I define arguments wiht CPU pointer in high-level API.
https://github.com/cupy/cupy/pull/1769/files#diff-da3b471a8f2bebf46bb07243ffb2caedR392

Please give me some advice.

and Do you know why this error occurs?
https://travis-ci.org/cupy/cupy/jobs/453816083#L846

unnonouno · 2018-11-15T00:35:55Z

In such case, using numpy.ndarray as an interface is enough in my opinion. > CPU pointer

unnonouno · 2018-11-15T00:37:22Z

You need to fix the dummy header file?

okuta · 2018-12-24T11:14:45Z

cupy/cudnn.pyx

@@ -382,6 +382,13 @@ def set_dropout_descriptor(desc, handle, dropout):
    cudnn.setDropoutDescriptor(desc.value, handle, dropout, 0, 0, 0)


+def create_ctc_loss_descriptor(data_type):


Cloud you rename this function or delete this?

Suggested change

def create_ctc_loss_descriptor(data_type):

def _create_ctc_loss_descriptor(data_type):

okuta · 2018-12-24T11:15:03Z

jenkins, test this please.

chainer-ci · 2018-12-24T12:33:14Z

Jenkins CI test (for commit 02df19a, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

kmaehashi · 2019-03-26T11:10:04Z

@aonotas Do you have some time to update this PR?

chainer-ci · 2019-03-26T12:22:36Z

Jenkins CI test (for commit 02df19a, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

aonotas · 2019-04-05T05:13:37Z

I fix the code (just rename the function).
Please review it! I'm sorry for my late PR.

okuta · 2019-04-05T09:19:52Z

chainerci please

okuta · 2019-04-05T09:50:04Z

jenkis, test this please.

chainer-ci · 2019-04-05T10:18:54Z

Jenkins CI test (for commit cb658d8, target branch master) failed with status FAILURE.

okuta · 2019-04-08T04:42:23Z

LGTM!

support ctc functions

2309250

aonotas changed the title ~~upport ctc functions~~ Support ctc functions Nov 1, 2018

aonotas changed the title ~~Support ctc functions~~ Support cuDNN CTC functions Nov 1, 2018

okuta self-assigned this Nov 2, 2018

okuta requested changes Nov 2, 2018

View reviewed changes

okuta and others added 2 commits November 2, 2018 12:06

Update cupy/cuda/cudnn.pyx

7219d31

Co-Authored-By: aonotas <nanigashi03@gmail.com>

Update cupy/cuda/cudnn.pyx

a939329

Co-Authored-By: aonotas <nanigashi03@gmail.com>

aonotas force-pushed the cudnn-ctc branch 2 times, most recently from 7b26f2d to c206bc6 Compare November 2, 2018 04:30

update getCTCLossWorkspaceSize

0fa284e

aonotas force-pushed the cudnn-ctc branch from c206bc6 to 0fa284e Compare November 2, 2018 04:31

aonotas and others added 2 commits November 12, 2018 14:53

add high-level ctc function

83f88a9

fix ctc_loss

19d93fa

This was referenced Nov 12, 2018

Support cuDNN CTC functions chainer/chainer#5650

Closed

The use of CuDNN CTC espnet/espnet#433

Closed

fix header file

7fa14f2

aonotas force-pushed the cudnn-ctc branch from d8337bf to 7fa14f2 Compare November 19, 2018 01:59

aonotas added 2 commits November 19, 2018 11:13

fix header file for CTC

ed10e3b

fix flake8

754f368

aonotas force-pushed the cudnn-ctc branch from 4e63dc2 to 754f368 Compare November 19, 2018 03:41

aonotas added 2 commits November 19, 2018 13:33

Merge branch 'master' of github.com:cupy/cupy into cudnn-ctc

dcd64de

fix flake8

bf0550d

aonotas force-pushed the cudnn-ctc branch from e489be6 to bf0550d Compare November 19, 2018 04:46

use numpy.ndarray

02df19a

okuta approved these changes Dec 3, 2018

View reviewed changes

okuta added cat:feature New features/APIs to-be-backported Pull-requests to be backported to stable branch labels Dec 3, 2018

okuta added this to the v6.0.0b2 milestone Dec 3, 2018

okuta requested changes Dec 24, 2018

View reviewed changes

hvy modified the milestones: v6.0.0b2, v6.0.0b3 Jan 24, 2019

beam2d removed this from the v6.0.0b3 milestone Feb 28, 2019

aonotas added 2 commits April 5, 2019 14:05

rename _create_ctc_loss_descriptor

d0cc91c

Merge branch 'master' into cudnn-ctc

cb658d8

okuta removed the to-be-backported Pull-requests to be backported to stable branch label Apr 8, 2019

okuta added this to the v7.0.0a1 milestone Apr 8, 2019

okuta merged commit b40438e into cupy:master Apr 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support cuDNN CTC functions #1769

Support cuDNN CTC functions #1769

aonotas commented Nov 1, 2018 •

edited

okuta Nov 2, 2018

aonotas Nov 2, 2018 •

edited

okuta Nov 7, 2018

okuta Dec 24, 2018 •

edited

okuta commented Nov 2, 2018

chainer-ci commented Nov 2, 2018

aonotas commented Nov 6, 2018

aonotas commented Nov 12, 2018 •

edited

unnonouno commented Nov 15, 2018

unnonouno commented Nov 15, 2018

okuta Dec 24, 2018 •

edited

okuta commented Dec 24, 2018

chainer-ci commented Dec 24, 2018

kmaehashi commented Mar 26, 2019

chainer-ci commented Mar 26, 2019

aonotas commented Apr 5, 2019

okuta commented Apr 5, 2019

okuta commented Apr 5, 2019

chainer-ci commented Apr 5, 2019

okuta commented Apr 8, 2019

		@@ -382,6 +382,13 @@ def set_dropout_descriptor(desc, handle, dropout):
		cudnn.setDropoutDescriptor(desc.value, handle, dropout, 0, 0, 0)


		def create_ctc_loss_descriptor(data_type):

	def create_ctc_loss_descriptor(data_type):
	def _create_ctc_loss_descriptor(data_type):

Support cuDNN CTC functions #1769

Support cuDNN CTC functions #1769

Conversation

aonotas commented Nov 1, 2018 • edited

okuta Nov 2, 2018

Choose a reason for hiding this comment

aonotas Nov 2, 2018 • edited

Choose a reason for hiding this comment

okuta Nov 7, 2018

Choose a reason for hiding this comment

okuta Dec 24, 2018 • edited

Choose a reason for hiding this comment

okuta commented Nov 2, 2018

chainer-ci commented Nov 2, 2018

aonotas commented Nov 6, 2018

aonotas commented Nov 12, 2018 • edited

unnonouno commented Nov 15, 2018

unnonouno commented Nov 15, 2018

okuta Dec 24, 2018 • edited

Choose a reason for hiding this comment

okuta commented Dec 24, 2018

chainer-ci commented Dec 24, 2018

kmaehashi commented Mar 26, 2019

chainer-ci commented Mar 26, 2019

aonotas commented Apr 5, 2019

okuta commented Apr 5, 2019

okuta commented Apr 5, 2019

chainer-ci commented Apr 5, 2019

okuta commented Apr 8, 2019

aonotas commented Nov 1, 2018 •

edited

aonotas Nov 2, 2018 •

edited

okuta Dec 24, 2018 •

edited

aonotas commented Nov 12, 2018 •

edited

okuta Dec 24, 2018 •

edited