Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overfow in matmul test #2403

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Fix overfow in matmul test #2403

merged 2 commits into from
Apr 1, 2020

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Aug 14, 2019

Fixes #2334

@niboshi niboshi added cat:test Test code / CI to-be-backported Pull-requests to be backported to stable branch labels Aug 14, 2019
toslunar
toslunar approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

#2334 remains open until the other tests are fixed.

@toslunar
Copy link
Member

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit c4a9fb4:

@toslunar toslunar self-assigned this Aug 14, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit c4a9fb4, target branch master) failed with status FAILURE.

@toslunar
Copy link
Member

Not equal to tolerance rtol=0.001, atol=0.001 😔

@niboshi
Copy link
Member Author

niboshi commented Aug 15, 2019

Hm, how can I fix this? 🤔
Adjusting tolerances?

@toslunar toslunar added this to the v8.0.0b1 milestone Jan 28, 2020
@niboshi
Copy link
Member Author

niboshi commented Feb 21, 2020

Fixed by using shaped_random instead of shaped_arange.

@toslunar
Copy link
Member

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 72ea491:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 72ea491, target branch master) succeeded!

@emcastillo emcastillo modified the milestones: v8.0.0b1, v8.0.0b2 Mar 23, 2020
@kmaehashi
Copy link
Member

/test
Testing again using the latest master.

cc/ @toslunar

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 72ea491:

@toslunar toslunar merged commit b3dac61 into cupy:master Apr 1, 2020
@toslunar toslunar mentioned this pull request Apr 1, 2020
Merged
toslunar added a commit to toslunar/cupy that referenced this pull request Apr 1, 2020
@toslunar
Merge pull request cupy#2403 from niboshi/test-fix-matmul-overflow
9290290 
Fix overfow in `matmul` test
@niboshi niboshi deleted the test-fix-matmul-overflow branch April 1, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees

@toslunar toslunar

Labels
cat:test Test code / CI to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Milestone
v8.0.0b2
Development

Successfully merging this pull request may close these issues.

Overflow warning in CI
6 participants
@niboshi @toslunar @pfn-ci-bot @chainer-ci @kmaehashi @emcastillo