Improve reduction core #2697
Merged
Improve reduction core #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for my late review. Could you resolve conflicts? |
asi1024
added
the
cat:performance
okuta
force-pushed
the
improve-reduction-core
branch
from
ed46fe3
to
86c0564
Compare
|
I rebased. |
|
jenkins, test this please. |
|
Successfully created a job for commit 86c0564: |
|
Jenkins CI test (for commit 86c0564, target branch master) succeeded! |
|
This PR is just for code simplification? I compared the performance between this branch and by using cupy-perf, but I saw no performance improvement. |
|
This PR focuses simplify. |
asi1024
added
cat:code-fix
asi1024
reviewed
Dec 2, 2019
Co-Authored-By: Akifumi Imanishi <akifumi.imanishi@gmail.com>
|
jenkins, test this please. |
|
Successfully created a job for commit a339f3a: |
|
Jenkins CI test (for commit a339f3a, target branch master) succeeded! |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
_get_reduction_argsto remove duplicated code.Please merge #2689 before this PR.