Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hiprtc support #3238

Merged
merged 4 commits into from
Aug 25, 2020
Merged

Add hiprtc support #3238

merged 4 commits into from
Aug 25, 2020

Conversation

emcastillo
Copy link
Member

@emcastillo emcastillo commented Mar 30, 2020 •
edited
Loading

Merge after #3237

Allows using hiprtc

Thanks to @okuta for nvrtc->hiprtc bindings

@emcastillo emcastillo added the hip Topic: AMD ROCm / HIP label Mar 30, 2020
@emcastillo
Copy link
Member Author

Probably

cupy/cupy/cuda/compiler.py

Line 120 in c3eb998

options += ('-arch=compute_{}'.format(arch),)

Needs some tunning

leofang
leofang reviewed Mar 31, 2020
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a neat change 👍 Didn't realize it's that easy to "overload" nvrtc to support its HIP counterpart. I was expecting additional wrappers like compile_using_hiprtc to be written.

I just left a few nitpick comments.

cupy/cuda/compiler.py Outdated Show resolved Hide resolved
cupy/cuda/compiler.py Outdated Show resolved Hide resolved
cupy/cuda/cupy_rtc.h Outdated Show resolved Hide resolved
cupy/cuda/compiler.py Outdated Show resolved Hide resolved
@kmaehashi kmaehashi self-assigned this Mar 31, 2020
@emcastillo emcastillo added this to the v8.0.0b3 milestone May 13, 2020
@emcastillo emcastillo modified the milestones: v8.0.0b3, v8.0.0b4 May 29, 2020
@asi1024 asi1024 modified the milestones: v8.0.0b4, v8.0.0b5 Jun 24, 2020
@emcastillo emcastillo modified the milestone: v8.0.0b5 Jun 25, 2020
@asi1024 asi1024 removed this from the v8.0.0b5 milestone Jul 29, 2020
@leofang leofang mentioned this pull request Aug 23, 2020
Merged
@leofang
Copy link
Member

leofang commented Aug 24, 2020

I'd like to have this PR also blocked by #3823.

@emcastillo
Copy link
Member Author

rebased, Jenkins test this please

@emcastillo
Copy link
Member Author

Jenkins, test this please

@cupy cupy deleted a comment from chainer-ci Aug 24, 2020
@chainer-ci
Copy link
Member

Jenkins CI test (for commit c5c0940, target branch master) failed with status FAILURE.

@emcastillo
Copy link
Member Author

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 25522a2, target branch master) succeeded!

@emcastillo
Copy link
Member Author

PTAL

leofang
leofang approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll rebase #3823 after this is in.

@kmaehashi kmaehashi merged commit cfce416 into cupy:master Aug 25, 2020
@kmaehashi
Copy link
Member

LGTM!

@leofang leofang mentioned this pull request Aug 25, 2020
Closed
@kmaehashi kmaehashi added this to the v8.0.0rc1 milestone Aug 27, 2020
@emcastillo emcastillo deleted the hiprtc branch March 18, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang approved these changes

Assignees

@kmaehashi kmaehashi

Labels
hip Topic: AMD ROCm / HIP
Projects
None yet
Milestone
v8.0.0rc1
Development

Successfully merging this pull request may close these issues.
5 participants
@emcastillo @leofang @chainer-ci @kmaehashi @asi1024