Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix boolean indexing #3538

Merged
merged 1 commit into from Jul 6, 2020
Merged

Fix boolean indexing #3538

merged 1 commit into from Jul 6, 2020

Conversation

okuta
Copy link
Member

@okuta okuta commented Jul 3, 2020

Fix #627
We can use

import cupy
b = cupy.ones((1,1))
b[0, True] = 2

@okuta okuta added cat:bug Bugs cat:numpy-compat Follow the NumPy/SciPy spec changes labels Jul 3, 2020
@kmaehashi kmaehashi added this to the v8.0.0rc1 milestone Jul 6, 2020
@emcastillo
Copy link
Member

Jenkins, test this please

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit bc669d3:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit bc669d3, target branch master) succeeded!

@emcastillo emcastillo added the st:test-and-merge (deprecated) Ready to merge after test pass. label Jul 6, 2020
@mergify mergify bot merged commit 78a0b0e into cupy:master Jul 6, 2020
@emcastillo emcastillo added to-be-backported Pull-requests to be backported to stable branch and removed cat:numpy-compat Follow the NumPy/SciPy spec changes labels Jul 6, 2020
@emcastillo emcastillo mentioned this pull request Jul 6, 2020
Closed
emcastillo pushed a commit to emcastillo/cupy that referenced this pull request Jul 6, 2020
@mergify
Merge pull request cupy#3538 from okuta/enhance-boolean-indexing
e649a9e 
Enhance boolean indexing
@emcastillo emcastillo changed the title Enhance boolean indexing Fix boolean indexing Jul 6, 2020
@chainer-ci
Copy link
Member

Jenkins CI test (for commit bc669d3, target branch master) succeeded!

@okuta okuta deleted the enhance-boolean-indexing branch July 9, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emcastillo emcastillo

Labels
cat:bug Bugs st:test-and-merge (deprecated) Ready to merge after test pass. to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Milestone
v8.0.0b5
Development

Successfully merging this pull request may close these issues.

IndexError when we use indexing with combination of int and boolean.
5 participants
@okuta @emcastillo @pfn-ci-bot @chainer-ci @kmaehashi