Add cupy_backends/cuda/libs/cutensor.pxd
#3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kmaehashi
added
the
blocking
kmaehashi
removed
the
blocking
asi1024
force-pushed
the
cythonize-cutensor
branch
from
97a16a5
to
1590d30
Compare
Merged
asi1024
changed the title
cupy.cutensorcupy_backends/cuda/libs/cutensor.pxd
|
@kmaehashi PTAL! |
asi1024
commented
Jul 31, 2020
|
|
||
| cdef class Handle: | ||
|
|
||
| cdef void* _ptr |
There was a problem hiding this comment.
This PR changes the type of member variable _ptr, because cutensorHandle_t is declared in the pyx file.
asi1024
force-pushed
the
cythonize-cutensor
branch
from
4a1bc63
to
1590d30
Compare
|
Jenkins, test this please. |
|
Successfully created a job for commit 1590d30: |
|
Jenkins CI test (for commit 1590d30, target branch master) succeeded! |
kmaehashi
reviewed
Aug 6, 2020
cupy_setup_build.py
Outdated
| @@ -83,6 +83,7 @@ | |||
| 'cupy.cuda.function', | |||
| 'cupy.cuda.stream', | |||
| 'cupy.cuda.texture', | |||
| 'cupy.cutensor', | |||
There was a problem hiding this comment.
Could you move this under cutensor module?
|
LGTM except comment. |
|
LGTM! |
|
Successfully created a job for commit eb60ce8: |
kmaehashi
added
st:test-and-merge
|
Jenkins CI test (for commit eb60ce8, target branch master) succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
cupy_backends/cuda/libs/cutensor.pxdand cythonizescupy.cutensor.Further performance improvement will be worked in another PR: #3700