allow non-contiguous array input to binary morphology functions #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcastillo
approved these changes
Oct 9, 2020
|
Jenkins, test this please |
emcastillo
added
the
st:test-and-merge
|
Jenkins CI test (for commit 911eec8, target branch master) succeeded! |
|
@emcastillo This pull-request is marked as |
|
Jenkins, test this please |
|
Jenkins CI test (for commit 2c605ad, target branch master) succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to other ndimage functions, the input does not have to be C contiguous for the binary erosion kernel. Test cases were added to verify this.
A typo in spelling
cupy.asfortranarraywas fixed in themaskcode path as well.