Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow non-contiguous array input to binary morphology functions #4058

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Oct 2, 2020

Similar to other ndimage functions, the input does not have to be C contiguous for the binary erosion kernel. Test cases were added to verify this.

A typo in spelling cupy.asfortranarray was fixed in the mask code path as well.

@kmaehashi kmaehashi added cat:enhancement Improvements to existing features prio:medium labels Oct 5, 2020
@emcastillo
Copy link
Member

Jenkins, test this please

@emcastillo emcastillo added this to the v9.0.0a1 milestone Oct 9, 2020
@emcastillo emcastillo added the st:test-and-merge (deprecated) Ready to merge after test pass. label Oct 9, 2020
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 911eec8, target branch master) succeeded!

@chainer-ci
Copy link
Member

@emcastillo This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@emcastillo
Copy link
Member

Jenkins, test this please

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 2c605ad, target branch master) succeeded!

@mergify mergify bot merged commit 77ece3e into cupy:master Oct 13, 2020
@grlee77 grlee77 deleted the ndimage_binary_morphology_contiguity branch December 18, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Improvements to existing features prio:medium st:test-and-merge (deprecated) Ready to merge after test pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants