Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xfail tests for manipulation dims under HIP/ROCm #4662

Merged
merged 2 commits into from Mar 4, 2021

Conversation

takagi
Copy link
Member

@takagi takagi commented Feb 13, 2021

Rel #4132, #4484.

@kmaehashi kmaehashi added prio:high hip Topic: AMD ROCm / HIP labels Feb 15, 2021
]

def _check_broadcast_arrays_hip_skip_condition(self):
return self.shapes in self._broadcast_arrays_hip_skip_condition
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can put all together in a function? 😄

def _hip_skip_invalid_broadcast(self):
    invalid_shapes = [
        [(1,), (1,)],
        [(2,), (2,)],
    ]
    if runtime.is_hip and self.shapes in invalid_shapes:
        pytest.xfail('HIP/ROCm may have a bug')

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed as such!

@emcastillo emcastillo added the st:awaiting-author Awaiting response from author label Feb 18, 2021
@takagi takagi removed the st:awaiting-author Awaiting response from author label Feb 26, 2021
@takagi
Copy link
Member Author

takagi commented Mar 3, 2021

pfnCI, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 2d5679e, target branch master) succeeded!

@emcastillo emcastillo added the st:test-and-merge (deprecated) Ready to merge after test pass. label Mar 4, 2021
@mergify mergify bot merged commit 91155e1 into cupy:master Mar 4, 2021
@emcastillo emcastillo added this to the v9.0.0rc1 milestone Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hip Topic: AMD ROCm / HIP prio:high st:test-and-merge (deprecated) Ready to merge after test pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants