Xfail tests for manipulation dims under HIP/ROCm #4662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcastillo
reviewed
Feb 18, 2021
| ] | ||
|
|
||
| def _check_broadcast_arrays_hip_skip_condition(self): | ||
| return self.shapes in self._broadcast_arrays_hip_skip_condition |
There was a problem hiding this comment.
We can put all together in a function? 😄
def _hip_skip_invalid_broadcast(self):
invalid_shapes = [
[(1,), (1,)],
[(2,), (2,)],
]
if runtime.is_hip and self.shapes in invalid_shapes:
pytest.xfail('HIP/ROCm may have a bug')
takagi
force-pushed
the
test-hip-manipulation-dims
branch
from
9dd28fd
to
2d5679e
Compare
|
pfnCI, test this please. |
|
Jenkins CI test (for commit 2d5679e, target branch master) succeeded! |
emcastillo
added
the
st:test-and-merge
emcastillo
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel #4132, #4484.