Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert FP16 headers from CUDA 12.2.0 to CUDA 12.1.1 #7758

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

kmaehashi
Copy link
Member

@kmaehashi kmaehashi commented Jul 26, 2023

Follows-up #7748. FP16 headers from CUDA 12.2.0 added dependency to vector_types.h, vector_functions.h, cuda_runtime_api.h, etc., causing compilation errors in environment without these headers.

CUDA 12.1.1:

% grep '#include' /usr/local/cuda-12.1.1/include/cuda_fp16.h
/usr/local/cuda-12.1.1/include/cuda_fp16.h:#include "cuda_fp16.hpp"

CUDA 12.2.0:

% grep '#include' /usr/local/cuda-12.2.0/include/cuda_fp16.h
/usr/local/cuda-12.2.0/include/cuda_fp16.h:#include "vector_types.h"
/usr/local/cuda-12.2.0/include/cuda_fp16.h:#include "vector_functions.h"
/usr/local/cuda-12.2.0/include/cuda_fp16.h:#include "cuda_fp16.hpp"

% grep '#include' /usr/local/cuda-12.2.0/include/vector_types.h
#include "crt/host_defines.h"

% grep '#include' /usr/local/cuda-12.2.0/include/vector_functions.h
#include "cuda_runtime_api.h"
#include "vector_functions.hpp"

@kmaehashi
Copy link
Member Author

/test mini

@kmaehashi kmaehashi added cat:bug Bugs to-be-backported Pull-requests to be backported to stable branch blocking Issue/pull-request is mandatory for the upcoming release labels Jul 26, 2023
@kmaehashi kmaehashi added this to the v13.0.0b1 milestone Jul 26, 2023
@emcastillo emcastillo disabled auto-merge July 27, 2023 00:59
@kmaehashi kmaehashi marked this pull request as draft July 27, 2023 04:36
@kmaehashi
Copy link
Member Author

kmaehashi commented Jul 27, 2023

This PR failed on CUDA 12.2 for Windows:

c:\program files\nvidia gpu computing toolkit\cuda\v12.2\include\cuda_bf16.hpp(575): error: no instance of overloaded function "__half::__half" matches the specified type

@leofang
Copy link
Member

leofang commented Aug 1, 2023

I'd suggest to merge & revert for now.

@kmaehashi
Copy link
Member Author

For record: no difference in FP16 headers between 12.2.0 and 12.2.1.

@kmaehashi
Copy link
Member Author

/test mini

@kmaehashi kmaehashi marked this pull request as ready for review August 3, 2023 13:05
@kmaehashi
Copy link
Member Author

Tests passed except for CUDA 12.2 on Windows. It seems CUDA 12.2 for Linux is not affected.

@kmaehashi
Copy link
Member Author

kmaehashi commented Aug 4, 2023

Let's proceed to merge. I will:

@emcastillo emcastillo merged commit bf8a53b into cupy:main Aug 4, 2023
57 of 58 checks passed
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Aug 4, 2023
Revert FP16 headers from CUDA 12.2.0 to CUDA 12.1.1
@kmaehashi kmaehashi deleted the fp16-cuda12.1 branch August 4, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking Issue/pull-request is mandatory for the upcoming release cat:bug Bugs to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants