-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert FP16 headers from CUDA 12.2.0 to CUDA 12.1.1 #7758
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test mini |
kmaehashi
added
cat:bug
Bugs
to-be-backported
Pull-requests to be backported to stable branch
blocking
Issue/pull-request is mandatory for the upcoming release
labels
Jul 26, 2023
emcastillo
approved these changes
Jul 27, 2023
This PR failed on CUDA 12.2 for Windows:
|
I'd suggest to merge & revert for now. |
For record: no difference in FP16 headers between 12.2.0 and 12.2.1. |
/test mini |
Tests passed except for CUDA 12.2 on Windows. It seems CUDA 12.2 for Linux is not affected. |
Let's proceed to merge. I will:
|
emcastillo
approved these changes
Aug 4, 2023
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
Aug 4, 2023
Revert FP16 headers from CUDA 12.2.0 to CUDA 12.1.1
This was referenced Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocking
Issue/pull-request is mandatory for the upcoming release
cat:bug
Bugs
to-be-backported
Pull-requests to be backported to stable branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows-up #7748. FP16 headers from CUDA 12.2.0 added dependency to
vector_types.h
,vector_functions.h
,cuda_runtime_api.h
, etc., causing compilation errors in environment without these headers.CUDA 12.1.1:
CUDA 12.2.0: