Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes for CUDA 12.2 on Windows support #7777

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

kmaehashi
Copy link
Member

@kmaehashi kmaehashi commented Aug 4, 2023

@kmaehashi kmaehashi added to-be-backported Pull-requests to be backported to stable branch blocking Issue/pull-request is mandatory for the upcoming release prio:high labels Aug 4, 2023
@emcastillo emcastillo self-assigned this Aug 7, 2023
@@ -6,7 +6,7 @@ Requirements

* `NVIDIA CUDA GPU <https://developer.nvidia.com/cuda-gpus>`_ with the Compute Capability 3.0 or larger.

* `CUDA Toolkit <https://developer.nvidia.com/cuda-toolkit>`_: v11.2 / v11.3 / v11.4 / v11.5 / v11.6 / v11.7 / v11.8 / v12.0 / v12.1 / v12.2
* `CUDA Toolkit <https://developer.nvidia.com/cuda-toolkit>`_: v11.2 / v11.3 / v11.4 / v11.5 / v11.6 / v11.7 / v11.8 / v12.0 / v12.1 / v12.2 [#cuda112windows]_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
This is the rendered doc, I just give it another thought and maybe it is better to specify (linux only)?
I think it is not very important but just a quick note :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point is that CUDA 12.2 for Windows is totally fine for most users with CUDA Toolkit installed, except for environments without headers...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems only supported footnote syntax is numbers (1, 2, 3, ...) or symbols (*, ✝️, ...)
https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#footnotes

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is fine, it can be seen at a glance so no prob!

@emcastillo emcastillo merged commit 3d0440e into cupy:main Aug 7, 2023
22 checks passed
@chainer-ci
Copy link
Member

@emcastillo Failed to backport automatically.


Not cleanly cherry-picked

@kmaehashi kmaehashi deleted the update-cuda122-win-doc branch August 7, 2023 08:26
kmaehashi pushed a commit to kmaehashi/cupy that referenced this pull request Aug 7, 2023
Add notes for CUDA 12.2 on Windows support
@kmaehashi kmaehashi added the cat:document Documentation label Aug 7, 2023
@kmaehashi kmaehashi added this to the v13.0.0b1 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking Issue/pull-request is mandatory for the upcoming release cat:document Documentation prio:high to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants