Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent Failure? Tufts::WorkflowSetup grants the workflow approval role to all members of the hyrax admin group #260

Closed
mark-dce opened this issue Sep 19, 2017 · 3 comments · Fixed by #324
Assignees
Labels

Comments

@mark-dce
Copy link
Contributor

mark-dce commented Sep 19, 2017

commit: 1bc5445
seed: ??? (shoot)

  1) Tufts::WorkflowSetup grants the workflow approval role to all members of the hyrax admin group
     Failure/Error:
       expect(role_names).to contain_exactly(
         "publishing"
       )
     
       expected collection contained:  ["publishing"]
       actual collection contained:    ["managing", "publishing"]
       the extra elements were:        ["managing"]
     # ./spec/lib/tufts/workflow_setup_spec.rb:31:in `block (2 levels) in <top (required)>'
@no-reply
Copy link
Collaborator

It's possible this one was fixed by #269.

@no-reply
Copy link
Collaborator

no-reply commented Sep 21, 2017

Nevermind. I have a seed for this one:
47596 on 2e3ed9e


I can't reproduce with the seed above.

@bess
Copy link
Contributor

bess commented Sep 28, 2017

I fixed this by changing what the test is testing for. In order for our publication workflow to work, we need the "publishing" role to exist. Sometimes a "managing" role is also being created for some reason (this is the result of some confusion between application roles and workflow roles, I believe). We aren't using the "managing" role, so we don't really care whether it exists or not. I changed the test to more specifically only test whether the publishing role exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants