Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup workflow for all feature specs #269

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Setup workflow for all feature specs #269

merged 1 commit into from
Sep 21, 2017

Conversation

no-reply
Copy link
Collaborator

@no-reply no-reply commented Sep 20, 2017

Workflow is now setup during database cleaning before all feature specs. The
:workflow tag is introduced to example metadata to handle setup for
non-feature specs that need workflow.

This reduces the amount of duplication and specialized knowledge needed to setup
workflow for a test. It also fixes several order-dependent spec failures due to
unsatisfactory workflow setup in some existing feature specs.

Closes #264.

Workflow is now setup during database cleaning before all feature specs. The
`:workflow` tag is introduced to example metadata to handle setup for
non-feature specs that need workflow.

This reduces the amount of duplication and specialized knowledge needed to setup
workflow for a test. It also fixes several order-dependent spec failures due to
unsatisfactory workflow setup in some existing feature specs.
Copy link
Contributor

@bess bess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks like a great way to do this, @no-reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent Failure: Couldn't find Hyrax::PermissionTemplate
2 participants