Use mira_publication_workflow and hyrax actor stack for self-deposit contributions #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…contributions Add feature test for capstone contribute Persist depositor to fedora object (enables "my works" behavior) Pdfs created via contribute should use default admin set and mira_publication_workflow Use AttachFilesToWorkJob to attach uploaded file Creation of default admin set now happens in db:seed, which is run in db:setup Using Tufts::WorkflowSetup.setup instead of creating default admin set directly will avoid intermittent test failures Enable customized notifications
|
@bess I'm handing this back to you for the final merge. The contents should be those from your original PR, rebased on #255, #253, and with a fix for what I think is an errant configuration change (see: #248 (comment)). If things look good to you, and I haven't misunderstood something, I'm 👍 on merging this. |
|
Looks like travis is still failing :( . I have to go catch a train. I will leave it up to you whether the test failures are significant (they don't look relevant to this merge to me, and I see on slack the team is having some conversations about intermittent test failures, but it's up to you). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature test for capstone contribute
Persist depositor to fedora object (enables "my works" behavior)
Pdfs created via contribute should use default admin set and mira_publication_workflow
Use AttachFilesToWorkJob to attach uploaded file
Creation of default admin set now happens in db:seed, which is run in db:setup
Using Tufts::WorkflowSetup.setup instead of creating default admin set directly will avoid intermittent test failures
Enable customized notifications
This is a rebased and slightly modified version of number #248.
Fixes #245
Fixes #3
Fixes #5
Fixes #235