Multiple 'RCPT TO': Fix boolean expressions fo C89 (2)

curl · Jan 15, 2020 · 089704f · 089704f
1 parent 1d5936d
commit 089704f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/smtp.c b/lib/smtp.c
@@ -915,15 +915,17 @@ static CURLcode smtp_state_rcpt_resp(struct connectdata *conn, int smtpcode,
   CURLcode result = CURLE_OK;
   struct Curl_easy *data = conn->data;
   struct SMTP *smtp = data->req.protop;
+  bool is_smtp_err = FALSE;
+  bool is_smtp_blocking_err = FALSE;
 
   (void)instate; /* no use for this yet */
 
-  bool is_smtp_err = smtpcode/100 != 2 ? TRUE : FALSE;
+  is_smtp_err = (smtpcode/100 != 2) ? TRUE : FALSE;
 
   /* If there's multiple "RCPT TO" to be issued, it's possible to ignore errors
      and proceed with only the valid addresses. */
-  bool is_smtp_blocking_err =
-    is_smtp_err && !data->set.mail_rcpt_ignore_invalid ? TRUE : FALSE;
+  is_smtp_blocking_err =
+    (is_smtp_err && !data->set.mail_rcpt_ignore_invalid) ? TRUE : FALSE;
 
   if(is_smtp_err) {
     /* Remembering the last failure which we can report if all "RCPT TO" have