Skip to content

Commit

Permalink
Pass remote_port to MsH3ConnectionOpen
Browse files Browse the repository at this point in the history
MsH3 supported additional "Port" parameter to connect not hosted on
443 port QUIC website.

* https://github.com/nibanks/msh3/releases/tag/v0.3.0
* nibanks/msh3#37
  • Loading branch information
unasuke committed Apr 27, 2022
1 parent e07a9b6 commit 2e20931
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/HTTP3.md
Expand Up @@ -144,7 +144,7 @@ Build curl:

Build msh3:

% git clone -b v0.1.0 --single-branch --recursive https://github.com/nibanks/msh3
% git clone -b v0.3.0 --single-branch --recursive https://github.com/nibanks/msh3
% cd msh3 && mkdir build && cd build
% cmake -G 'Unix Makefiles' -DCMAKE_BUILD_TYPE=RelWithDebInfo ..
% cmake --build .
Expand All @@ -165,7 +165,7 @@ Run from `/usr/local/bin/curl`.

Build msh3:

% git clone -b v0.2.0 --single-branch --recursive https://github.com/nibanks/msh3
% git clone -b v0.3.0 --single-branch --recursive https://github.com/nibanks/msh3
% cd msh3 && mkdir build && cd build
% cmake -G 'Visual Studio 17 2022' -DCMAKE_BUILD_TYPE=RelWithDebInfo ..
% cmake --build . --config Release
Expand Down
7 changes: 5 additions & 2 deletions lib/vquic/msh3.c
Expand Up @@ -95,7 +95,7 @@ static const MSH3_REQUEST_IF msh3_request_if = {

void Curl_quic_ver(char *p, size_t len)
{
(void)msnprintf(p, len, "msh3/%s", "0.0.1");
(void)msnprintf(p, len, "msh3/%s", "0.3.0");
}

CURLcode Curl_quic_connect(struct Curl_easy *data,
Expand All @@ -121,7 +121,10 @@ CURLcode Curl_quic_connect(struct Curl_easy *data,
return CURLE_FAILED_INIT;
}

qs->conn = MsH3ConnectionOpen(qs->api, conn->host.name, unsecure);
qs->conn = MsH3ConnectionOpen(qs->api,
conn->host.name,
(uint16_t)conn->remote_port,
unsecure);
if(!qs->conn) {
failf(data, "can't create msh3 connection");
if(qs->api) {
Expand Down

0 comments on commit 2e20931

Please sign in to comment.