Skip to content

Commit

Permalink
Makefile.am: fix portability issues
Browse files Browse the repository at this point in the history
Commit a04f0b9 made me notice that
there is a portability issue in curl's top-level Makefile.am.

$< can only be used in rules that deal with .SUFFIXES.  Its use
for general prerequisites is a GNU make extension.

$< could be replaced by $?, but I think in an autotools context,
something like this is better:

Bug: https://curl.se/mail/lib-2022-05/0024.html
Closes #8861
  • Loading branch information
Christian Weisgerber via curl-library authored and bagder committed May 19, 2022
1 parent dfa84a0 commit 46f11a4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -279,13 +279,13 @@ uninstall-hook:
(cd docs && $(MAKE) uninstall)
(cd docs/libcurl && $(MAKE) uninstall)

ca-bundle: scripts/mk-ca-bundle.pl
ca-bundle: $(srcdir)/scripts/mk-ca-bundle.pl
@echo "generating a fresh ca-bundle.crt"
@perl $< -b -l -u lib/ca-bundle.crt
@perl $(srcdir)/scripts/mk-ca-bundle.pl -b -l -u lib/ca-bundle.crt

ca-firefox: scripts/firefox-db2pem.sh
ca-firefox: $(srcdir)/scripts/firefox-db2pem.sh
@echo "generating a fresh ca-bundle.crt"
$< lib/ca-bundle.crt
$(srcdir)/scripts/firefox-db2pem.sh lib/ca-bundle.crt

checksrc:
(cd lib && $(MAKE) checksrc)
Expand Down

0 comments on commit 46f11a4

Please sign in to comment.