Skip to content

Commit

Permalink
ntlm_wb: do not use data->state.buf any longer
Browse files Browse the repository at this point in the history
Closes #12787
  • Loading branch information
icing authored and bagder committed Jan 25, 2024
1 parent c93f95a commit 8e9c304
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/curl_ntlm_wb.c
Expand Up @@ -266,7 +266,7 @@ static CURLcode ntlm_wb_response(struct Curl_easy *data, struct ntlmdata *ntlm,
size_t len_in = strlen(input), len_out = 0;
struct dynbuf b;
char *ptr = NULL;
unsigned char *buf = (unsigned char *)data->state.buffer;
usigned char buf[1024]

This comment has been minimized.

Copy link
@uwes-ufo

uwes-ufo Jan 31, 2024

should it be

- usigned char buf[1024]
+ unsigned char buf[1024];

?

This comment has been minimized.

Copy link
@icing

icing Jan 31, 2024

Author Contributor

yes, see #12825

Curl_dyn_init(&b, MAX_NTLM_WB_RESPONSE);

while(len_in > 0) {
Expand All @@ -284,7 +284,7 @@ static CURLcode ntlm_wb_response(struct Curl_easy *data, struct ntlmdata *ntlm,
/* Read one line */
while(1) {
ssize_t size =
wakeup_read(ntlm->ntlm_auth_hlpr_socket, buf, data->set.buffer_size);
wakeup_read(ntlm->ntlm_auth_hlpr_socket, buf, sizeof(buf));
if(size == -1) {
if(errno == EINTR)
continue;
Expand Down

0 comments on commit 8e9c304

Please sign in to comment.