New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ntml_wb, fix buffer type #12825
ntml_wb, fix buffer type #12825
Conversation
lib/curl_ntlm_wb.c
Outdated
@@ -266,7 +266,7 @@ static CURLcode ntlm_wb_response(struct Curl_easy *data, struct ntlmdata *ntlm, | |||
size_t len_in = strlen(input), len_out = 0; | |||
struct dynbuf b; | |||
char *ptr = NULL; | |||
usigned char buf[1024] | |||
unsigned char buf[1024] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing semicolon at the end as well 😅
This mistake was not detected by CI because currently the configure script is broken and cannot enable NTLM_WB since the check requires a detected A fix for that configure mistake exists in #12479 but we have held off on merging that on purpose since NTLM_WB is scheduled to get removed in June 2024. |
lib/curl_ntlm_wb.c
Outdated
@@ -266,7 +266,7 @@ static CURLcode ntlm_wb_response(struct Curl_easy *data, struct ntlmdata *ntlm, | |||
size_t len_in = strlen(input), len_out = 0; | |||
struct dynbuf b; | |||
char *ptr = NULL; | |||
usigned char buf[1024] | |||
unsigned char buf[1024] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsigned char buf[1024] | |
unsigned char buf[1024]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you want it all!
Follow-up to 8e9c304
Reported-by: tranzystorekk