Intentionally avoid checking if the address of SystemFunction036, a.k.a.

RtlGenRandom, has been located or not. This function is only available on WinXP and later. When unavailable c-ares uses portable rand() function.
curl · May 18, 2009 · a450efb · a450efb
1 parent 0cf8d4f
commit a450efb
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/ares/ares.h b/ares/ares.h
@@ -98,7 +98,6 @@ extern "C" {
 #define ARES_ELOADIPHLPAPI           21
 #define ARES_ELOADADVAPI32           22
 #define ARES_EADDRGetNetworkParams   23
-#define ARES_EADDRSYSTEMFUNCTION036  24
 
 /* Flag values */
 #define ARES_FLAG_USEVC         (1 << 0)

diff --git a/ares/ares_library_init.c b/ares/ares_library_init.c
@@ -51,12 +51,12 @@ static int ares_win32_init(void)
 
   fpSystemFunction036 = (fpSystemFunction036_t)
     GetProcAddress(hnd_advapi32, "SystemFunction036");
-  if (!fpSystemFunction036)
-    {
-      FreeLibrary(hnd_advapi32);
-      FreeLibrary(hnd_iphlpapi);
-      return ARES_EADDRSYSTEMFUNCTION036;
-    }
+
+  /*
+   * Intentionally avoid checking if the address of SystemFunction036, a.k.a.
+   * RtlGenRandom, has been located or not. This function is only available on
+   * WinXP and later. When unavailable c-ares uses portable rand() function.
+   */
 
 #endif
   return ARES_SUCCESS;

diff --git a/ares/ares_strerror.c b/ares/ares_strerror.c
@@ -46,8 +46,7 @@ const char *ares_strerror(int code)
     "Illegal hints flags specified",
     "Error loading iphlpapi.dll",
     "Error loading advapi32.dll",
-    "Unknown GetNetworkParams function address",
-    "Unknown SystemFunction036 function address"
+    "Could not find GetNetworkParams function"
   };
 
   if(code >= 0 && code < (int)(sizeof(errtext) / sizeof(*errtext)))