Skip to content

Commit

Permalink
rtsp: don't let CSeq error override earlier errors
Browse files Browse the repository at this point in the history
- When done, if an error has already occurred then don't check the
  sequence numbers for mismatch.

A sequence number may not have been received if an error occurred.

Prior to this change a sequence mismatch error would override earlier
errors. For example, a server that returns nothing would cause error
CURLE_GOT_NOTHING in Curl_http_done which was then overridden by
CURLE_RTSP_CSEQ_ERROR in rtsp_done.

Closes #8525
  • Loading branch information
jay committed Mar 18, 2022
1 parent d3cb3be commit acf46b1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/rtsp.c
Expand Up @@ -219,7 +219,7 @@ static CURLcode rtsp_done(struct Curl_easy *data,

httpStatus = Curl_http_done(data, status, premature);

if(rtsp) {
if(rtsp && !status && !httpStatus) {
/* Check the sequence numbers */
long CSeq_sent = rtsp->CSeq_sent;
long CSeq_recv = rtsp->CSeq_recv;
Expand Down

0 comments on commit acf46b1

Please sign in to comment.